Conversation
* Bump golangci-lint version to v2.11.4 for Go 1.25.9 support * Migrate .golangci.yaml to v2 configuration format * Remove deprecated linters integrated into staticcheck - gosimple (now part of staticcheck) - stylecheck (now part of staticcheck) * Remove formatters from linters list - gofmt (now a formatter, not a linter) - goimports (now a formatter, not a linter) * Remove typecheck (always enabled by default in v2) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
| - devenv | ||
| linters: | ||
| disable-all: true | ||
| disable: |
There was a problem hiding this comment.
In golangci-lint v2, there are "Enabled by default linters" (errcheck, govet, ineffassign, staticcheck, unused) that are active even with disable-all: true. So we do need the disable section to override these defaults.
Temporarily disable linters that report pre-existing code quality issues unrelated to the Go 1.25.9 upgrade to make CI pass: * errcheck - 50 unchecked errors (mostly logger calls and defers) * staticcheck - 4 code simplifications (De Morgan's law, fmt usage) * gosec - 10 security warnings (test/dummy code with weak permissions) * noctx - 4 missing context (legacy code using net.Dial, http.NewRequest) * revive - 48 style issues (missing comments, unused parameters) These can be addressed in separate code quality improvement PRs. Removed unused exclude-rules for disabled linters and legacy deadcode references that no longer exist in golangci-lint v2. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
A major update and cleanup is proposed as part of this PR. We carry over many linting issues since this is already a legacy code base. Ideally we would address the linting issues, but since infrawatch/sg-core is in maintenance mode and no new code is being added I don't think we should work on fixing those. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2576aaafec0d4aa6bf2869a4f214361c ❌ stf-crc-ocp_418-local_build FAILURE in 27m 50s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6a0b724e8ff64bfc985f7f4ba322b37b ❌ stf-crc-ocp_418-local_build FAILURE in 26m 49s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a049c527fcdb4e88afc4fc32d3cadca8 ✔️ stf-crc-ocp_418-local_build SUCCESS in 46m 21s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/154ee338ce8549978732ef59132f16cf ❌ stf-crc-ocp_418-local_build FAILURE in 27m 58s |
|
recheck |
|
CI is unstable, not related to this change |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c181108427b940d6b65e8fe4a47a98ee ❌ stf-crc-ocp_418-local_build RETRY_LIMIT in 20m 09s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ca9b526c43ad4f758d13571fec53837f ❌ stf-crc-ocp_418-local_build RETRY_LIMIT in 3m 34s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/091193baee5d41ea8218337f59514760 ✔️ stf-crc-ocp_418-local_build SUCCESS in 46m 14s |
* Update to golang 1.25.9 Closes-Bug: https://redhat.atlassian.net/browse/OSPRH-28974 Closes-Bug: https://redhat.atlassian.net/browse/OSPRH-27803 * Update golangci-lint to v2.11.4 * Bump golangci-lint version to v2.11.4 for Go 1.25.9 support * Migrate .golangci.yaml to v2 configuration format * Remove deprecated linters integrated into staticcheck - gosimple (now part of staticcheck) - stylecheck (now part of staticcheck) * Remove formatters from linters list - gofmt (now a formatter, not a linter) - goimports (now a formatter, not a linter) * Remove typecheck (always enabled by default in v2) * Disable linters with existing code quality issues Temporarily disable linters that report pre-existing code quality issues unrelated to the Go 1.25.9 upgrade to make CI pass: * errcheck - 50 unchecked errors (mostly logger calls and defers) * staticcheck - 4 code simplifications (De Morgan's law, fmt usage) * gosec - 10 security warnings (test/dummy code with weak permissions) * noctx - 4 missing context (legacy code using net.Dial, http.NewRequest) * revive - 48 style issues (missing comments, unused parameters) These can be addressed in separate code quality improvement PRs. Removed unused exclude-rules for disabled linters and legacy deadcode references that no longer exist in golangci-lint v2. (cherry picked from commit f3f9180) Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
3 participants
Update to golang 1.25.9 and golangci-lint 2.11.4