[FIX] product_catalog_tree: add context validation in product catalog… #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential error in the product_catalog_tree module by adding context validation to prevent crashes when the required context variables are missing. The changes ensure that _compute_catalog_values and _inverse_catalog_values methods exit gracefully when res_model or order_id are not present in the context.
- Adds early return guards to prevent
Nonevalues being passed toself.env[res_model].browse(order_id) - Improves robustness of compute and inverse methods by validating required context before execution
| res_model = self._context.get("product_catalog_order_model") | ||
| order_id = self._context.get("order_id") | ||
|
|
||
| if not res_model or not order_id: |
There was a problem hiding this comment.
Corrected spelling of 'prodcut' to 'product' in PR title.
lav-adhoc
changed the title
Contributor
|
@roboadhoc r+ |
roboadhoc
pushed a commit
that referenced
this pull request
Oct 23, 2025
… compute methods closes #792 Signed-off-by: matiasperalta1 <mnp@adhoc.com.ar>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… compute methods