make EventDateUnionAggregator only emit dates, if feeding FiltersNode… #3750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoniTUB
approved these changes
Jun 12, 2025
backend/src/main/java/com/bakdata/conquery/apiv1/query/concept/specific/CQConcept.java
Outdated
Show resolved
Hide resolved
| @Override | ||
| public void collectRequiredTables(Set<Table> requiredTables) { | ||
| requiredTables.addAll(this.requiredTables); | ||
| requiredTables.addAll(getRequiredTables()); |
Collaborator
There was a problem hiding this comment.
Das würde doch reichen oder?
Suggested change
| requiredTables.addAll(getRequiredTables()); | |
| if(owner != null) { | |
| { | |
| requiredTables.addAll(owner.getRequiredTables()); | |
| } |
Collaborator
Author
There was a problem hiding this comment.
das funktioniert nicht wegen Rekursion
… is actually contained. This avoids cases, where dates are improperly combined with multiple connectors
awildturtok
force-pushed
the
feature/date-agg-aggregated
branch
from
ea93e40 to
575e789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is actually contained.
This avoids cases, where dates are improperly combined with multiple connectors