Add StaticAssetUrlProvider to provide URLs for assets in dev/prod #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides simple cache-busted local URLs in development environments, and remote (e.g. cloud storage / s3) urls in production.
acoulton
force-pushed
the
feat-1.x-static-assets
branch
from
dbce280 to
cc25548
Compare
The test doesn't always fail on travis, possibly some crossover between testcases somehow? Though that's not really supposed to be happening. Use a randomised key name so it defo can't conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides simple cache-busted local URLs in development environments,
and remote (e.g. cloud storage / s3) urls in production.