Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust APIs #292

Merged
merged 78 commits into from
Dec 12, 2023
Merged

Update Rust APIs #292

merged 78 commits into from
Dec 12, 2023

Commits on Oct 3, 2023

  1. fix memory error in single_stage_multi_reduction_kernel (#235) 

    * refactor

* refactor

* revert

* refactor: clang format

* Update icicle/appUtils/msm/msm.cu
    @ImmanuelSegol
    ImmanuelSegol authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    9114ecb View commit details
    Browse the repository at this point in the history

  2. Added separate device context struct, returned lde

    @DmytroTym
    DmytroTym committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    33d1583 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into cuda_refactoring

    @DmytroTym
    DmytroTym committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    1c14466 View commit details
    Browse the repository at this point in the history

  4. wip - msm and eq

    Vitalii committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    3de0e79 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. added lde to cmake

    @DmytroTym
    DmytroTym committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    df1fc7e View commit details
    Browse the repository at this point in the history

  2. wip draft with msm correctness test for bls12_381 + Merge commit 'df1… 

    …fc7ed6068e8eab9d81a8d6002949524597a19' into develop/vhnat/feat-233-update-api-fix-rust-build
    Vitalii committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    3e9c0e7 View commit details
    Browse the repository at this point in the history

  3. Montgomery param added in lde.cu mul function

    @DmytroTym
    DmytroTym committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d8e26e8 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/feat/233-update-api' into deve… 

    …lop/vhnat/feat-233-update-api-fix-rust-build
    Vitalii committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    f1819d9 View commit details
    Browse the repository at this point in the history

  5. fixed on_device for ntt and lde

    @DmytroTym
    DmytroTym committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    7d4e266 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. CamelCase

    @DmytroTym
    DmytroTym committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ec67196 View commit details
    Browse the repository at this point in the history

  2. fixed msm_test, int unification, google guilde

    @DmytroTym
    DmytroTym committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d6dfd59 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feat/233-update-api' into cuda_refactoring

    @DmytroTym
    DmytroTym committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    09ef4fd View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Merge commit '09ef4fdba19e6c4e4745c80062bb02a9bcc70d87' into develop/… 

    …vhnat/feat-233-update-api-fix-rust-build
    Vitalii committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    6f44433 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. wip - ntt crash debugging

    Vitalii committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    fda01fa View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Hotfix to go regression when 2 curves are imported (#245) 

    Hotfix to slowdown in go when more than one curve is imported.
    @DmytroTym
    DmytroTym authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    028bed1 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Merge branch 'feat/233-update-api' into develop/dima/feat-233-update-… 

    …rust-apis
    @DmytroTym
    DmytroTym committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    1d892b2 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Exclude target directory from format checks (#247)

    @jeremyfelder
    jeremyfelder authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1cf7b2e View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. [CI]: Add concurrency groups at workflow level (#238) 

    Add concurrency groups at workflow level for CI. Remove dev CI since we no longer use dev branch. Resolves #180
    @jeremyfelder
    jeremyfelder authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    88c9c85 View commit details
    Browse the repository at this point in the history

  2. Fix readme badge links, fix CI cpp formatter (#249)

    @jeremyfelder
    jeremyfelder authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    09d8c5d View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Support bw6-761 (#188) 

    Resolves #191 and #113

---------

Co-authored-by: DmytroTym <dmytrotym1@gmail.com>
Co-authored-by: ImmanuelSegol <3ditds@gmail.com>
    @liuxiaobleach @DmytroTym @ImmanuelSegol
    3 people authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    fd62fe5 View commit details
    Browse the repository at this point in the history

  2. async MSM with a rust wrapper

    @DmytroTym
    DmytroTym committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    3e7d7b9 View commit details
    Browse the repository at this point in the history

  3. wip ntt tests with corretness

    Vitalii committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    141b1c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. hotfix for correctness > 2^9

    Vitalii committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    a199bc8 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. wip on device inout mixing with correctness

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ea00037 View commit details
    Browse the repository at this point in the history

  2. cleanup

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b8a06d5 View commit details
    Browse the repository at this point in the history

  3. preserving twiddles after first call

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    13f75a2 View commit details
    Browse the repository at this point in the history

  4. fixed twiddles preserving

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6bcc56b View commit details
    Browse the repository at this point in the history

  5. formatting

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    bb36b1b View commit details
    Browse the repository at this point in the history

  6. removed some printing

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    466b669 View commit details
    Browse the repository at this point in the history

  7. disable ecntt temporarily

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ac5b850 View commit details
    Browse the repository at this point in the history

  8. format

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    bb98347 View commit details
    Browse the repository at this point in the history

  9. rust fmt

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    434a010 View commit details
    Browse the repository at this point in the history

  10. exclude target from format

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    70eeada View commit details
    Browse the repository at this point in the history

  11. passing ntt after merge

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    286811f View commit details
    Browse the repository at this point in the history

  12. hotfix for linking issue

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1b2c03b View commit details
    Browse the repository at this point in the history

  13. format

    Vitalii committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    20ca1e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Merge commit '133a1b28bc04900272e7121692c2e5bc2d8dcbcf' into develop/… 

    …vhnat/feat-233-update-api
    Vitalii committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0b2bd78 View commit details
    Browse the repository at this point in the history

  2. format

    Vitalii committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    27d2c8f View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. draft of pr comments + correctness restored

    Vitalii committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    ec86b44 View commit details
    Browse the repository at this point in the history

  2. wip refactor + format

    Vitalii committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    9556ecf View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. domain wip

    Vitalii committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    b0d0215 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. rust format

    Vitalii committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d0569b4 View commit details
    Browse the repository at this point in the history

  2. Merged feature branch in and Rust MSM correctness

    @DmytroTym
    DmytroTym committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    dd628ed View commit details
    Browse the repository at this point in the history

  3. rust build for correct curve

    @DmytroTym
    DmytroTym committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    36442ae View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Slowdown fixed by passing release flag to cmake

    @DmytroTym
    DmytroTym committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ac6593d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'vitaliy/develop/vhnat/feat-233-update-a… 

    …pi' into develop/dima/feat-233-update-rust-apis
    @DmytroTym
    DmytroTym committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    32eaef1 View commit details
    Browse the repository at this point in the history

  3. fix typos in logs (#255)

    @vuittont60
    vuittont60 authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a469fb5 View commit details
    Browse the repository at this point in the history

  4. Fix typos (#257)

    @omahs
    omahs authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5c868ab View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. WIP field and curve

    @DmytroTym
    DmytroTym committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    eb543f0 View commit details
    Browse the repository at this point in the history

  2. still wip field and curve

    @DmytroTym
    DmytroTym committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    318c6f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Two curve NTT correctness issue hotfix (#254)

    @DmytroTym
    DmytroTym authored Nov 5, 2023
    Configuration menu
    Copy the full SHA
    e4e9130 View commit details
    Browse the repository at this point in the history

  2. field and curve in rust 1.0

    @DmytroTym
    DmytroTym committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    4ad37ae View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Refactored rust into several crates

    @DmytroTym
    DmytroTym committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    7cc105d View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Arkworks is now an option, bn254 crate created

    @DmytroTym
    DmytroTym committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e13bf8b View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Rust msm and ntt wip

    @DmytroTym
    DmytroTym committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    45c9b00 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. include colab (#261)

    @ImmanuelSegol
    ImmanuelSegol authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    29cad66 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. separable compilation for Rust (#244) 

    separable compilation for Rust #244
    @vhnatyk
    vhnatyk authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    7baea7c View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. A version of rust msm done, cuda runtime wrapped

    @DmytroTym
    DmytroTym committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    1623f01 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. refactor rust by creating a curve folder

    @DmytroTym
    DmytroTym committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    69dc6c1 View commit details
    Browse the repository at this point in the history

  2. vec_ops instead of lde for now

    @DmytroTym
    DmytroTym committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    e34e936 View commit details
    Browse the repository at this point in the history

  3. format

    @DmytroTym
    DmytroTym committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    5a96065 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. Update bug_issue.md 

    Update bug issue template to apply correct label
    @jeremyfelder
    jeremyfelder authored Nov 26, 2023
    Configuration menu
    Copy the full SHA
    5813f29 View commit details
    Browse the repository at this point in the history

  2. Update feature_request.md (#278)

    @jeremyfelder
    jeremyfelder authored Nov 26, 2023
    Configuration menu
    Copy the full SHA
    2790f18 View commit details
    Browse the repository at this point in the history

  3. Rust/large bucket factor msm (#271) 

    * Update rust bindings to support large_bucket_factor parameter
* Special treatment of ones in MSM removed

---------
Co-authored-by: DmytroTym <dmytrotym1@gmail.com>
    @jeremyfelder
    jeremyfelder authored Nov 26, 2023
    Configuration menu
    Copy the full SHA
    856629d View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Docs: Clarify enabling tests in cmake build process (#288) 

    Docs: Emphasize enabling tests in cmake build process
    @bigsky77
    bigsky77 authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    fad317a View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. fixed cmake

    @DmytroTym
    DmytroTym committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    c42c26f View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Improved modular multiplier (#289) 

    Out implementation of Barrett modular multiplication improved by utilising Karatsuba multiplication and more careful optimisations of lsb and msb multipliers in reduction stage
    @DmytroTym
    DmytroTym authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    f8610dd View commit details
    Browse the repository at this point in the history

  2. Very rough CUDA-side NTT API blueprint

    @DmytroTym
    DmytroTym committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    af7de7d View commit details
    Browse the repository at this point in the history

  3. Another iteration of ntt.cuh

    @DmytroTym
    DmytroTym committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    bd9ccc6 View commit details
    Browse the repository at this point in the history

  4. fix

    @DmytroTym
    DmytroTym committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    0c87502 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. CUDA-side NTT that compiles

    @DmytroTym
    DmytroTym committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8a824d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Rust NTT prototype v0.1

    @DmytroTym
    DmytroTym committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    00f965e View commit details
    Browse the repository at this point in the history

  2. forgotten files

    @DmytroTym
    DmytroTym committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    14103a7 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Merge commit 'dfa5b10adbf7f63f3a3d0e0adb5cfc7b10508b19' into develop/… 

    …dima/feat-233-update-rust-apis
    @DmytroTym
    DmytroTym committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    d764b0d View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. Fixed NTT correctness for all sizes, cmake patched

    @DmytroTym
    DmytroTym committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    0a55625 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. NTT: separated butterfly from inverse/direct NTT

    @DmytroTym
    DmytroTym committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    03c2592 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. NTT: in coset only gen is exposed; inv twiddles removed

    @DmytroTym
    DmytroTym committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    98a3030 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into develop/dima/feat-233-update-rust-apis

    @DmytroTym
    DmytroTym committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    8887761 View commit details
    Browse the repository at this point in the history