make install doesn't copy everything needed? git-core/../ext/ missing?

[woodsnick]

It seems like "make install" may not transfer everything that git-subrepo wants. On macOS Sierra I run a make install which transfers everything like the following:

install -d -m 0755 /usr/local/Cellar/git/2.11.0/libexec/git-core/ install -C -m 0755 lib/git-subrepo /usr/local/Cellar/git/2.11.0/libexec/git-core/ install -d -m 0755 /usr/local/Cellar/git/2.11.0/libexec/git-core/git-subrepo.d/ install -C -m 0755 lib/git-subrepo.d/help-functions.bash lib/git-subrepo.d/bash+.bash /usr/local/Cellar/git/2.11.0/libexec/git-core/git-subrepo.d/ install -d -m 0755 /usr/local/share/man/man1/ install -C -m 0644 man/man1/git-subrepo.1 /usr/local/share/man/man1/

But then running tests shows errors like:

test/branch-all.t ........... /usr/local/Cellar/git/2.11.0/libexec/git-core/git-subrepo: line 25: /usr/local/Cellar/git/2.11.0/libexec/git-core/../ext/bashplus/lib/bash+.bash: No such file or directory test/branch-all.t ........... No subtests run test/branch.t ............... Died at line 52 in subrepo-clone-bar-into-foo of test/setup test/branch.t ............... No subtests run test/clean.t ................ Died at line 52 in subrepo-clone-bar-into-foo of test/setup

It appears that the ext/bashplus/* content is in the git-subrepo project just not transferred to the system folder maybe? Wanted to see if that was expected or if I am doing anything else wrong. I already am sourcing all of the git-subrepo .rc related files so interesting that the system installed version gets picked up even.

My .bash_profile additions:

source ~/Scripts/git-subrepo/.rc source ~/Scripts/git-subrepo/share/git-completion.bash source ~/Scripts/git-subrepo/share/completion.bash

[woodsnick]

Note: Just running a "make uninstall" then running the tests works so just a problem with the installed variant it seems?

[grimmySwe]

I will see if I can test this on MacOS to see what happening.

[farazhussain]

'make uninstall' followed my 'make test' worked for me on 0.3.1. Thanks @woodsnick.

[grimmySwe]

I have to admit that I never run make install, i just have my repo and then perform the install step from it with sourcing the .rc file.

[grimmySwe]

@ingydotnet what are the use cases for make install, if I look at the start page it's a little hidden down below

[ingydotnet]

make install is supposed to copy the relevant files into the places they would exist if subrepo was a core/contrib git command. ie into the directory found with git --exec-path.

I haven't tried it in a long time. It might need some help.

You can run it to install into a throwaway directory (for testing) like this:

DESTDIR=throwaway make install

Let me know if it isn't doing the rights things.

[farazhussain]

Using DESTDIR made it work for me.