Skip to content

refactor: Async scan, code refactoring#71

Merged
Floodnut merged 2 commits intodevfrom
feature/#70-refactor-scan
Apr 3, 2023
Merged

refactor: Async scan, code refactoring#71
Floodnut merged 2 commits intodevfrom
feature/#70-refactor-scan

Conversation

@Floodnut
Copy link
Copy Markdown
Member

@Floodnut Floodnut commented Apr 1, 2023

Update

  • Hot Fix
  • Release
  • Develop
  • Others

Description

refactoring for Scan API

Update Summary

  • Change AsyncScan Logic to thenCombineAsync.
  • Add Async Request method for ApiFeignClient.
  • Refactor ScanService.

New/Edited policies

Resolved Issue

Unresolved Issue

Test

  • Unit Test
  • Build Test

Proof Check

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Floodnut Floodnut self-assigned this Apr 1, 2023
@Floodnut Floodnut merged commit b956ae7 into dev Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant