fix(flashbots): Do not block on submission #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason to block the entire loop on the time it takes to send the bundle and record metrics. This can happen in a spawned task while the loop just waits for the next value.
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
I'm also OK with not committing to this change now, and start tracking network request time. |
This was referenced Nov 25, 2025
prestwich
requested changes
Nov 25, 2025
| let flashbots = self.flashbots().to_owned(); | ||
| let signer = self.signer.clone(); | ||
|
|
||
| tokio::spawn(async move { |
Member
There was a problem hiding this comment.
this is not instrumented correctly. instrument the outer async move, then use in_current-span for the inner one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no point of blocking when we send the bundle to flashbots. The only thing we do after is record metrics. This will matter more on a production environment where network lag could occur on services we don't control (flashbots). I think blocking on quincey/getting the nonce on
prepareis OK.