fix: SignetEthBundleDriver now enforces market rules internally #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
reviewed
Aug 20, 2025
| // error our simulation. | ||
| if result.is_success() { | ||
| if self.check_fills(&mut t).is_err() | ||
| && !self.bundle.reverting_tx_hashes().contains(tx_hash) |
Member
There was a problem hiding this comment.
that's actually kind of funny. someone could mark a fill as reverting. In what situation would that actually be desirable? 🤔
Member
Author
There was a problem hiding this comment.
someone can mark any transaction as reverting, and that's okay, the rules are still enforced :)
Evalir
approved these changes
Aug 20, 2025
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
meant to approve earlier. lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Order enforcement to the bundle execution driver :)
A limitation of this is that it doesn't allow bundles that internally underfill (i.e. implicit dependencies on prior overfills)