Skip to content

Conversation

@prestwich
Copy link
Member

@prestwich prestwich commented Aug 21, 2025

adds tests for bundle guarantees

  • bundle can execute succesfully
  • bundle reverts on revert
  • bundle allows allow_reverting_hashes works
  • bundle with order can execute succesfully
  • bundle with order reverts on order dropped
  • bundle with order allow_reverting_hashes works when order dropped

Copy link
Member Author

prestwich commented Aug 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@prestwich prestwich force-pushed the prestwich/bundle-tests branch 2 times, most recently from f6925f7 to ae08440 Compare August 21, 2025 17:39
@prestwich prestwich force-pushed the prestwich/more-test-utils branch 2 times, most recently from 12adee5 to 69c57cf Compare August 21, 2025 18:29
@prestwich prestwich force-pushed the prestwich/bundle-tests branch from ae08440 to d67fb36 Compare August 21, 2025 18:29
@prestwich prestwich marked this pull request as ready for review August 21, 2025 18:41
@prestwich prestwich requested a review from a team as a code owner August 21, 2025 18:41
@prestwich prestwich changed the base branch from prestwich/more-test-utils to graphite-base/112 August 21, 2025 19:55
@prestwich prestwich force-pushed the prestwich/bundle-tests branch from ef797a2 to fb1afa2 Compare August 21, 2025 19:55
@prestwich prestwich changed the base branch from graphite-base/112 to main August 21, 2025 19:55
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

}

#[test]
fn test_order_bundle_revert() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test for providing a fill that is existing, but insufficient would be cool

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do we expect it to test that isn't already being tested?

@prestwich prestwich merged commit 0547177 into main Aug 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants