Skip to content

Conversation

@Evalir
Copy link
Member

@Evalir Evalir commented Sep 27, 2025

No description provided.

@Evalir Evalir requested a review from a team as a code owner September 27, 2025 10:10
Copy link
Member Author

Evalir commented Sep 27, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.


[workspace.package]
version = "0.10.2"
version = "0.11.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this semver breaking?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#116 this is generally how we've done it before, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think this is appropriate because downstream crates have relied on specific crate versions

@prestwich
Copy link
Member

test passes for me locally, so unsure if this is flakiness. let's replace that assert!( a == b ) with an assert_eq!

@Evalir Evalir requested a review from prestwich September 28, 2025 16:19
@Evalir Evalir merged commit 7c4764b into main Sep 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants