wip: add host sim #132
Open
wip: add host sim #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
changed the base branch from
prestwich/fill-builder
to
graphite-base/132
prestwich
force-pushed
the
graphite-base/132
branch
from
33415a3 to
d672bf5
Compare
prestwich
force-pushed
the
prestwich/host-sim-wip
branch
from
579a7a3 to
a853470
Compare
prestwich
changed the base branch from
graphite-base/132
to
prestwich/remove-host-fills
prestwich
force-pushed
the
prestwich/host-sim-wip
branch
from
a853470 to
19236a0
Compare
prestwich
changed the base branch from
prestwich/remove-host-fills
to
graphite-base/132
prestwich
force-pushed
the
prestwich/host-sim-wip
branch
from
554d991 to
01d39a5
Compare
prestwich
changed the base branch from
graphite-base/132
to
prestwich/remove-host-fills
Evalir
reviewed
Oct 31, 2025
| candidate_orders.absorb(&tx_orders); | ||
|
|
||
| // Then we check that the fills are sufficient against the | ||
| // provided fill state. This does nothing on error. |
There was a problem hiding this comment.
shouldn't this be does nothing on success?
Comment on lines
+209
to
+213
| // This is redundant with the driver, however, we double check here. | ||
| // If perf is hit too much we can remove. | ||
| self.rollup | ||
| .fill_state() | ||
| .check_ru_tx_events(&outputs.bundle_fills, &outputs.bundle_orders)?; |
There was a problem hiding this comment.
why double check? genuine question, want to understand the reasoning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip: add host sim
fix: add host evm and fix fill detection