refactor: i'm sorry #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
reviewed
May 29, 2025
| /// A trait for types that contain transactions. | ||
| pub trait HasTxns { | ||
| /// Get the transactions in the block. | ||
| fn transactions(&self) -> &[TransactionSigned]; |
Member
There was a problem hiding this comment.
maybe add transaction_count and into_transactions too?
Member
Author
There was a problem hiding this comment.
i don't think it's worth it, as this trait is basically a shim
prestwich
force-pushed
the
prestwich/this-was-not-a-good-idea
branch
from
ecef4d5 to
8b02178
Compare
Evalir
approved these changes
Jun 3, 2025
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
lgtm. i want to see how this will feel being used in the node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-_-
this PR removes reth dependencies from all crates, and aggregates the test utils into a single crate (with reth deps)
This involves some type duplication (in
signet_types::primitives). Those types are partially unfinished, and should be refined in future workto enable removing the dep,
trait Extractabletrait Extractablereth::primtivetypes have been swapped forsignet_types::primitivetypessignet-test-utilscrate