clarify between cache_rank and identifier
#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-carroll
changed the title
fee_score and identifiercache_rank and identifier
Evalir
reviewed
Jun 26, 2025
prestwich
reviewed
Jun 27, 2025
prestwich
reviewed
Jun 27, 2025
prestwich
reviewed
Jun 27, 2025
prestwich
reviewed
Jun 27, 2025
Member
|
ci should be fixed rebasing onto main after #80 |
anna-carroll
force-pushed
the
anna/rename-identifier-for-clarity
branch
from
7725537 to
ba6c12e
Compare
prestwich
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SimItems cache key was variably names as
score,identifier, andkey. However,scoreandidentifierare both also used elsewhere in this code to refer to different values. I found this to make the code less readable.This PR
cache_rank(the item's ordering within the cache) andscore(final, actual simulation score based on beneficiary balance change)cache_rankandidentifier(tx hash for txns, UUID for bundles)Also updates logging to use SimItem
identifier(rather thancache_rank) to make the logs more readable & searchable.