Skip to content

chore(sim): remove unnecessary Result for add_bundle #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025
Merged

chore(sim): remove unnecessary Result for add_bundle #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions crates/sim/src/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ impl SimCache {
/// Add an iterator of bundles to the cache. This locks the cache only once
///
/// Bundles added should have a valid replacement UUID. Bundles without a replacement UUID will be skipped.
pub fn add_bundles<I, Item>(&self, item: I, basefee: u64) -> Result<(), CacheError>
pub fn add_bundles<I, Item>(&self, item: I, basefee: u64)
where
I: IntoIterator<Item = Item>,
Item: Into<SignetEthBundle>,
Expand All @@ -134,8 +134,6 @@ impl SimCache {
let cache_rank = item.calculate_total_fee(basefee);
Self::add_inner(&mut inner, cache_rank, item, self.capacity);
}

Ok(())
}

/// Add a transaction to the cache.
Expand Down Expand Up @@ -285,7 +283,7 @@ mod test {

let cache = SimCache::with_capacity(2);

cache.add_bundles(items.clone(), 0).unwrap();
cache.add_bundles(items.clone(), 0);

assert_eq!(cache.len(), 2);
assert_eq!(cache.get(300), Some(items[2].clone().try_into().unwrap()));
Expand Down