chore(tests): Make timestamp divisible by 12 to conform to slot invariant #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iant Right now, this timestamp isn't divisible by 12. After fixing the bug we had on blob extraction on the node (https://github.com/init4tech/signet-node/pull/557/files#diff-c630b8329efc76498eaf78bdf3073dcdaefaacb9325e5731b7d1d8cae855d791R262), we now don't conform to an invariant that the calculator has when using `slot_ending_at`: The timestamp must be a slot boundary. We know if it's a slot boundary if it's divisible by 12 in the context of the start timestamp. For tests, this is 0, so any timestamp divisible by 12 will do.
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
requested changes
Jul 11, 2025
Member
prestwich
left a comment
prestwich
left a comment
There was a problem hiding this comment.
no need to make a release for this as all dependents rely on via github. This package is not published anyway, right?
Member
Author
|
Node depends on the released versions, but we can switch to github if we want 🤷 |
Member
|
no, the node depends on a github commit identified by a tag. signet-test-utils is not published |
Member
Author
|
in any case, i already removed the version bump |
prestwich
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this timestamp isn't divisible by 12. After fixing the bug we had on blob extraction on the node (https://github.com/init4tech/signet-node/pull/557/files#diff-c630b8329efc76498eaf78bdf3073dcdaefaacb9325e5731b7d1d8cae855d791R262), we now don't conform to an invariant that the calculator has when using
slot_ending_at: The timestamp must be a slot boundary. We know if it's a slot boundary if it's divisible by 12 in the context of the start timestamp. For tests, this is 0, so any timestamp divisible by 12 will do.