Revert "fix blue dot appears on inverted delegation on top left corner, refactor retrieving relationshipId in agents-core"

[dimaMachina]

Reverts #1153

was merged into #1146 branch

[linear]

Issue reopened: PRD-5435 @dima blue dot appears in the top left during animations sometimes

[changeset-bot]

⚠️ No Changeset found

Latest commit: 7cf44c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
agents-docs	Building	Preview	Comment	Dec 1, 2025 9:19pm
agents-manage-api	Building	Preview	Comment	Dec 1, 2025 9:19pm
agents-manage-ui	Building	Preview	Comment	Dec 1, 2025 9:19pm
agents-run-api	Building	Preview	Comment	Dec 1, 2025 9:19pm

[claude]

Claude finished @dimaMachina's task —— View job

---

TypeScript Staff Engineer Review

Todo List:

• Read repository documentation and context files
• Analyze each reverted file and understand the changes
• Evaluate the original problem vs. revert solution
• Assess system-level architectural implications
• Provide constructive feedback and recommendations
• Post final comprehensive review

---

Comprehensive Code Review

Context Understanding

This PR reverts #1153, which attempted to fix a visual bug (blue dot appearing in the top left corner during inverted delegation animations) and refactor relationshipId retrieval in agents-core. The revert was necessary because the original fix was merged into the wrong branch (#1146 instead of main) and potentially caused issues.

Critical Architectural Issues

🚨 HIGH PRIORITY: Incomplete Problem Resolution

Problem: The revert addresses a process issue but doesn't solve the underlying technical problem.

Analysis:

• Root Cause: The blue dot animation issue in default-edge.tsx:24-36 remains unfixed
• Impact: Users will continue experiencing the visual bug during inverted delegation animations
• Technical Debt: The original relationshipId refactoring was rolled back, potentially losing architectural improvements

Recommendation:

1. Immediate: Create a follow-up issue to re-implement the blue dot fix correctly
2. Process: Establish clear branching strategy to prevent similar merge confusion
3. Testing: Add visual regression tests for animation states

⚠️ MEDIUM PRIORITY: Tool Session Management Regression

Location: agents-run-api/src/agents/Agent.ts:588,613

Issue: The revert removes relationshipId tracking from MCP tool execution, which could impact:

• Tool audit trails
• Debugging delegated tool calls
• Performance monitoring of agent relationships

Code Impact:

// BEFORE (reverted): Clear relationship tracking
const relationshipId = mcpTools[index]?.relationshipId;
this.wrapTool(enhancedTool, streamRequestId, 'mcp', relationshipId, { needsApproval });

// AFTER: Loss of relationship context
this.wrapTool(enhancedTool, streamRequestId, 'mcp', undefined, { needsApproval });

Recommendation:

• Evaluate if relationshipId tracking provides value for observability
• If valuable, re-implement in a focused PR with proper testing
• Document the relationship between tools and agent relationships

⚠️ MEDIUM PRIORITY: Data Layer Simplification Loss

Location: packages/agents-core/src/data-access/subAgentRelations.ts

The revert removes what appears to be a refactored import or utility function. Without seeing the original change, this suggests:

• Potential loss of abstraction improvements
• Possible code duplication reintroduction

Positive Aspects

✅ Clean Revert Execution: The revert is well-executed with:

• Proper changeset removal
• Consistent code formatting maintained
• No merge conflicts or broken references

✅ Minimal Scope Impact: The revert touches only necessary files without broader system disruption

System-Level Concerns

1. Animation System Architecture

The default-edge.tsx component handles complex animation states:

// Current animation logic that may have issues
const isInvertedDelegating = status === 'inverted-delegating';
return (
  <circle fill="var(--primary)" r="6">
    <animateMotion
      ref={ref}
      dur="2s"
      path={edgePath}
      fill={isInvertedDelegating ? 'remove' : 'freeze'}
      {...(isInvertedDelegating && {
        keyPoints: '1;0',
        keyTimes: '0;1',
      })}
    />
  </circle>
);

Architectural Questions:

• Is the animation coordinate system properly normalized?
• Are there race conditions between edge path calculations and animation start?
• Should animation state be managed at a higher level?

2. Agent Relationship Tracking Consistency

The codebase shows sophisticated agent relationship management, but the relationshipId handling seems inconsistent:

• Some tools get relationship context, others don't
• Unclear if this impacts A2A (Agent-to-Agent) communication tracing

3. Missing Error Boundaries

Critical Gap: No error handling visible for animation failures or tool relationship resolution issues.

Impact: Silent failures could make debugging production issues difficult.

Recommendations for Moving Forward

Immediate Actions (Next Sprint)

1. Create targeted bug fix PR for the blue dot animation issue
2. Add integration tests for inverted delegation animations
3. Document the branching/merge process to prevent future confusion

Medium-term Architecture Improvements

1. Implement visual regression testing for UI animations
2. Evaluate relationshipId tracking value - keep if it aids debugging/monitoring
3. Add error boundaries around animation and tool execution logic
4. Consider animation state management refactoring if bugs persist

Long-term System Design Considerations

1. Agent relationship observability: Implement comprehensive tracing for A2A operations
2. Animation architecture: Consider moving to a more declarative animation system
3. Tool execution monitoring: Add metrics for tool relationship resolution failures

Code Quality Assessment

• Maintainability: ✅ Good - Clean separation of concerns
• Testability: ⚠️ Moderate - Animation logic needs better test coverage
• Error Handling: ❌ Poor - Missing error boundaries for critical paths
• Documentation: ⚠️ Moderate - Code is readable but architectural decisions need documentation

Final Verdict

This revert is operationally necessary but architecturally incomplete. The team correctly prioritized stability over feature completion, but now needs a clear plan to address the underlying issues without creating technical debt.

Priority: Schedule immediate follow-up work to properly fix the blue dot animation and evaluate the relationshipId tracking architecture.