chore: add sharp and tsx for skill support#2152
Conversation
Required by the `/screengrabs` skill (from inkeep/team-skills) for screenshot capture annotation and TypeScript script execution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
This PR adds sharp (^0.34.5) and tsx (^4.21.0) as root devDependencies to support the /screengrabs skill from inkeep/team-skills for screenshot annotation and TypeScript script execution during PR enrichment.
🔴❗ Critical (0) ❗🔴
No critical issues identified.
🟠⚠️ Major (0) 🟠⚠️
No major issues identified.
🟡 Minor (0) 🟡
No minor issues identified.
💭 Consider (0) 💭
No items identified.
✅ APPROVE
Summary: Clean dependency addition. Both packages use permissive licenses (Apache-2.0, MIT) and the version ranges follow existing repo conventions. The lockfile churn is minimal and expected for sharp which has platform-specific binaries. Notably, tsx is already used elsewhere in the monorepo (7 packages) and in root scripts via pnpx tsx — adding it as a direct devDependency is a reasonable consolidation that will improve CI performance by eliminating repeated downloads.
⚠️ Note: Unable to formally approve this PR due to GitHub App permission limitations. This review recommends approval.
Discarded (6)
| Location | Issue | Reason Discarded |
|---|---|---|
package.json:95-96 |
Caret version ranges used | Explicitly consistent with repo patterns; no action needed per existing conventions |
pnpm-lock.yaml |
Lockfile churn | Informational; churn is proportional and expected for adding sharp |
package.json |
tsx already in repo | Positive observation; consolidates existing usage |
package.json:95 |
sharp has native bindings | Informational; CI caching mitigates install time impact |
package.json |
External skill consumer | Informational; acceptable for devDependencies |
package.json:95-96 |
License compliance | Positive finding; both licenses are permissive |
Reviewers (1)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-devops |
6 | 0 | 0 | 0 | 0 | 0 | 6 |
| Total | 6 | 0 | 0 | 0 | 0 | 0 | 6 |
Note: All findings were informational observations or explicitly marked as needing no action.
Summary
sharpandtsxas root devDependencies/screengrabsskill (frominkeep/team-skills) for screenshot annotation and TypeScript script execution during PR enrichmentTest plan
pnpm installsucceedspnpm test)🤖 Generated with Claude Code