Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 9934cc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
TL;DR — Upgrades TypeScript from 5.x to 6.0.2 across the entire monorepo. This is a major-version bump that requires removing Key changes
Summary | 37 files | 9 commits | base: TypeScript 6 upgrade and
|
There was a problem hiding this comment.
Clean TypeScript 6.0.2 upgrade. The mechanical changes (version bumps, baseUrl removal, src/ → relative import rewrites, lockfile) all look correct. One comment on the auth.ts provisionUser type annotation — it works but the Parameters<NonNullable<...>>[0] pattern is worth a second look for readability.
| async provisionUser({ | ||
| user, | ||
| provider, | ||
| }: Parameters<NonNullable<SSOOptions['provisionUser']>>[0]) { |
There was a problem hiding this comment.
This Parameters<NonNullable<SSOOptions['provisionUser']>>[0] annotation works but is fairly noisy. Would a standalone type alias (e.g. type ProvisionUserArgs = Parameters<NonNullable<SSOOptions['provisionUser']>>[0]) be cleaner, or does @better-auth/sso already export a dedicated type for this? Not blocking — just a readability thought.
There was a problem hiding this comment.
Looks good — approving. Clean TS6 upgrade with correct baseUrl removal, import path rewrites, and type fixes.
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
This PR cleanly upgrades TypeScript from 5.x to 6.0.2 across the monorepo. The changes are well-executed:
✅ Changes Validated
Package Updates (15 packages)
- All packages consistently upgraded to
typescript: ^6.0.2 - Version ranges are appropriate (caret allows minor/patch updates)
tsconfig.json Changes (7 files)
- Removal of
baseUrl: "."is the correct migration for TS 6.0 - TypeScript 6 changed how
baseUrlinteracts with path resolution, requiring explicit relative paths - The
@/.sourcepath fix in agents-docs (".source"→"./.source") is correct
Code Changes (auth.ts)
- Type annotations added for
provisionUsercallback usingParameters<NonNullable<SSOOptions['provisionUser']>>[0]— correct pattern for extracting function parameter types - Method shorthand syntax change (
customResolveMethod(ctx)) — equivalent behavior - Removal of explicit optional marker on
trustedOriginscallback — TypeScript infers the correct type from betterAuth's API
Import Path Migrations (11 files)
- Conversion from
src/path aliases to relative imports is the correct approach after removingbaseUrl - All paths are correctly resolved
💭 Consider (C) 💭
💭 1) packages/agents-mcp Pre-existing version split
Issue: packages/agents-mcp remains on TypeScript 5.8.3 while all other packages are on 6.0.2.
Why: This is intentional — typescript-eslint@8.x has a peer dependency constraint of typescript: '<6.0.0'. The split is necessary until typescript-eslint releases TS 6 support.
Fix: No action needed now. Consider tracking when typescript-eslint v9 releases with TS 6 support to unify versions.
Refs: packages/agents-mcp/package.json:42
✅ APPROVE
Summary: Clean TypeScript 6.0.2 upgrade with all necessary migration steps (baseUrl removal, relative imports, type annotations). CI validation will confirm the upgrade is complete. The agents-mcp version split is an acceptable constraint from typescript-eslint and doesn't affect this PR. 🎉
Reviewers (2)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-devops |
3 | 0 | 1 | 0 | 0 | 0 | 2 |
pr-review-standards |
0 | 0 | 0 | 0 | 0 | 0 | 0 |
| Total | 3 | 0 | 1 | 0 | 0 | 0 | 2 |
Note: DevOps findings about peer deps and changeset were discarded as not actionable (dev dependency doesn't require changeset per AGENTS.md).
Discarded (2)
| Location | Issue | Reason Discarded |
|---|---|---|
pnpm-lock.yaml |
Peer dependency warnings from @typescript-eslint/* packages | CI validation will catch any real issues; monorepo successfully uses split TS versions |
.changeset/ |
No changeset for TS upgrade | TypeScript is a devDependency; per AGENTS.md guidelines, internal tooling changes don't require changesets |
Ito Test Report ✅22 test cases ran. 22 passed. The unified run passed all 22 of 22 test cases with zero failures, showing stable behavior across authentication and routing, project list and full-definition retrieval, end-to-end project CRUD, scheduled trigger creation/editing, and dataset run-config workflows. Most importantly, adversarial and resilience checks confirmed strong safety and graceful handling: invalid login errors recovered cleanly, external returnUrl open-redirect attempts were contained, unauthorized dev-session bootstrap was rejected with 401 and no cookie issuance, XSS/query-parameter/traversal-style probes and cross-tenant tampering produced sanitized non-leaking responses, and stress/edge scenarios (double-submit, rapid toggles, deep-link refresh, back/forward loops, mobile viewport, and refresh during dialog edit) preserved usable, consistent UI state. ✅ Passed (22)Commit: Tell us how we did: Give Ito Feedback |
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
This re-review covers the delta since the previous review (718091f10ce7). The prior review already approved the main TypeScript 6.0.2 upgrade. The new changes are minimal configuration additions.
✅ Changes Validated (Delta)
Commit 3790a3bfb — agents-manage-ui/cypress/tsconfig.json
- Added
"ignoreDeprecations": "6.0"to suppress TS6 deprecation warnings - This is a valid workaround for Cypress-specific TypeScript configuration
Commit 52e655ce4 — packages/create-agents/tsconfig.json
- Added
"rootDir": "src"to correctly constrain the output directory structure - Aligns with the existing
"include": ["src"]directive
Merge from main (8e162c2a7)
- Brought in unrelated changes (signoz migration, schema normalization, tooltip providers)
- These were already reviewed and merged to main; no action needed
💭 Consider (C) 💭
💭 1) agents-manage-ui/cypress/tsconfig.json:10 Config inconsistency with ignoreDeprecations
Issue: The ignoreDeprecations: "6.0" flag masks a TS6 deprecation warning caused by having both verbatimModuleSyntax: true and allowSyntheticDefaultImports: true in the same config. These options are semantically redundant.
Why: Not blocking — this is a valid workaround that keeps CI green. However, 10 other tsconfig files in this repo have the same combination but don't require the flag suggests this Cypress config may benefit from cleanup later.
Fix: Consider removing allowSyntheticDefaultImports: true in a follow-up PR since it has no effect when verbatimModuleSyntax is enabled.
Refs: TypeScript docs: verbatimModuleSyntax
✅ APPROVE
Summary: Clean follow-up commits to finalize the TS6 upgrade. The ignoreDeprecations workaround is pragmatic and CI confirms everything builds correctly. The rootDir addition is correctly configured. Ship it! 🚀
Reviewers (1)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-devops |
2 | 0 | 1 | 0 | 0 | 0 | 1 |
| Total | 2 | 0 | 1 | 0 | 0 | 0 | 1 |
Discarded (1)
| Location | Issue | Reason Discarded |
|---|---|---|
packages/create-agents/tsconfig.json:11 |
rootDir addition | INFO-level validation — the change is correct and appropriate, no issue to raise |
|
@claude add a changeset |
|
Claude finished @dimaMachina's task in 1m 0s —— View job Adding changeset for TypeScript 6.0.2 upgrade
Added a patch changeset for all affected published packages: Commit: |
Co-authored-by: Dimitri POSTOLOV <dimaMachina@users.noreply.github.com>
There was a problem hiding this comment.
Clean upgrade overall — the baseUrl removal + import path migration is the right approach, and the auth.ts type fixes are well-done. Two items need attention before merge.
Not in diff — packages/agents-mcp stays on typescript: ~5.8.3. Intentional exclusion, or missed?
| "@hono/vite-dev-server": "^0.23.0", | ||
| "@types/node": "^20.12.0", | ||
| "typescript": "^5.4.0", | ||
| "typescript": "^6.0.2", |
There was a problem hiding this comment.
The create-agents-template/pnpm-lock.yaml still resolves typescript to 5.9.3 (with specifiers ^5.4.0 and 5.9.3). The lockfile needs to be regenerated to match these ^6.0.2 specifiers — otherwise pnpm install --frozen-lockfile will fail for users scaffolding from this template.
cd create-agents-template && pnpm install| "types": ["cypress", "node"], | ||
| "skipLibCheck": true, | ||
| "allowSyntheticDefaultImports": true, | ||
| "ignoreDeprecations": "6.0", |
There was a problem hiding this comment.
This suppresses deprecation warnings for target: "es6" (should be "es2015") and allowSyntheticDefaultImports (redundant with verbatimModuleSyntax). Fine as a stopgap, but worth a follow-up to clean up the deprecated options — es6 can become es2015 and allowSyntheticDefaultImports can likely be removed, which would eliminate the need for ignoreDeprecations entirely.
| "incremental": true, | ||
| "paths": { | ||
| "@/.source": [".source"], | ||
| "@/.source": ["./.source"], |
There was a problem hiding this comment.
Good catch fixing [".source"] to ["./.source"] — without baseUrl, paths are resolved relative to the tsconfig location, so the ./ prefix is now required.
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Inkeep Agent Framework Docs' |
Ito Test Report ✅17 test cases ran. 17 passed. Unified results show 17 executed test cases passed with 0 failures (plus one review segment with no completed outcomes), indicating stable behavior and no confirmed production defects in the covered local/non-production scope. Key findings were successful projects and scheduled-triggers workflows (load, create/run, edit persistence, mobile usability), correct auth/session hardening (deep-link redirect with returnUrl, dev-session fail-safe without loops, unauthorized dev-session blocked with 401 and no cookie), resilient security controls (cross-tenant tampering denied, stored XSS neutralized, malicious trigger input rejected, duplicate create/delete race actions controlled), deterministic /run/api/chat validation responses (400 for missing conversationId and malformed/valid time headers without 500s/hangs), and a disabled dataset-run-configs endpoint remaining non-exposed (404, no request loop). ✅ Passed (17)Commit: Tell us how we did: Give Ito Feedback |








































No description provided.