Update widget to use new agents-ui package#2941
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
TL;DR — Migrates the docs site widget from the legacy Key changes
Summary | 7 files | 1 commit | base: Widget package migration from
|
|
TL;DR — Migrates the docs site widget from the legacy Key changes
Summary | 7 files | 4 commits | base: Widget package migration from
|
There was a problem hiding this comment.
PR Review Summary
(2) Total Issues | Risk: Medium
🔴❗ Critical (1) ❗🔴
Inline Comments:
- 🔴 Critical:
styling.mdx:15Missed import migration — code example references removed@inkeep/cxkit-typespackage
🟠⚠️ Major (1) 🟠⚠️
🟠 1) .env.example New required env var not documented
Issue: The PR introduces a new required environment variable NEXT_PUBLIC_INKEEP_APP_ID in inkeep-script.tsx, but .env.example has not been updated to document this variable.
Why: The InkeepScript component now returns early (renders nothing) when either NEXT_PUBLIC_INKEEP_API_KEY or NEXT_PUBLIC_INKEEP_APP_ID is missing. Contributors cloning the repo won't know this variable is required, leading to silent widget failures.
Fix: Add to .env.example:
# ============ INKEEP DOCS WIDGET ============
# App ID for Inkeep chat widget in docs site (required for widget to render)
# NEXT_PUBLIC_INKEEP_APP_ID=Per the repo's adding-env-variables skill, all new env vars should be documented in .env.example with descriptions.
Refs:
- inkeep-script.tsx:12 — where
appIdis read - inkeep-script.tsx:112 — guard condition requiring both vars
🚫 REQUEST CHANGES
Summary: The package migration is clean overall, but there's a critical broken code example in the docs (line 15 of styling.mdx still imports from @inkeep/cxkit-types) and the new NEXT_PUBLIC_INKEEP_APP_ID env var should be documented. Both are quick fixes — see the inline suggestion for the import fix.
Discarded (0)
No findings were discarded.
Reviewers (3)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-standards |
1 | 0 | 0 | 0 | 1 | 0 | 0 |
pr-review-docs |
1 | 0 | 0 | 0 | 1 | 0 | 0 |
pr-review-devops |
5 | 1 | 0 | 0 | 0 | 0 | 0 |
| Total | 7 | 1 | 0 | 0 | 1 | 0 | 0 |
Note: pr-review-standards and pr-review-docs both flagged the same cxkit-types import issue (deduplicated to single inline comment). DevOps returned 4 INFO-level findings confirming clean dependency removal, proper lockfile updates, and no changeset requirement.
There was a problem hiding this comment.
Net positive cleanup — removes @inkeep/cxkit-react, drops client-side tool definitions, and migrates to @inkeep/agents-ui-cloud. Two issues worth addressing: a hardcoded search API key that should use an env var, and an apiKey variable that's now read but never passed to the config.
Claude Opus | 𝕏
| } as any, | ||
| }, | ||
| searchSettings: { | ||
| apiKey: '0ed8a392c5f1bd3e1c0fb91684932c932a2f6e9765e0344b', |
There was a problem hiding this comment.
This API key is now hardcoded in source. Previously, the key came from NEXT_PUBLIC_INKEEP_API_KEY. Even though NEXT_PUBLIC_ keys are browser-visible, hardcoding makes rotation harder and is inconsistent with how appId is handled via env var. Consider using the existing apiKey variable here instead:
| apiKey: '0ed8a392c5f1bd3e1c0fb91684932c932a2f6e9765e0344b', | |
| apiKey, |
There was a problem hiding this comment.
New commit addresses the hardcoded API key — searchSettings.apiKey now correctly uses the env var. Both review comments are resolved. LGTM.
Claude Opus | 𝕏
There was a problem hiding this comment.
PR Review Summary
(1) Total Issues | Risk: Low
🕐 Pending Recommendations (1)
- 🟠
scopeNew required env varNEXT_PUBLIC_INKEEP_APP_IDshould be documented in.env.example
💡 APPROVE WITH SUGGESTIONS
Summary: The critical import migration issue (styling.mdx:15 referencing @inkeep/cxkit-types) has been fixed in commit 773b0fe0f. The package migration is now complete. One item remains from the prior review: documenting NEXT_PUBLIC_INKEEP_APP_ID in .env.example per the repo's adding-env-variables skill.
Discarded (0)
No findings were discarded.
Reviewers (1)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
orchestrator |
1 | 0 | 0 | 0 | 0 | 1 | 0 |
| Total | 1 | 0 | 0 | 0 | 0 | 1 | 0 |
Note: Delta review — prior CRITICAL issue (import migration) has been fixed. Only the env var documentation item from the prior review remains pending.
There was a problem hiding this comment.
PR Review Summary
(1) Total Issues | Risk: Low
🕐 Pending Recommendations (1)
- 🟠
scopeNew required env varNEXT_PUBLIC_INKEEP_APP_IDshould be documented in.env.example
💡 APPROVE WITH SUGGESTIONS
Summary: Delta review of commit 09849e165 Fix ship examples. The changes correctly update the "Ship" UI guide snippets (js-script-tag.ts and react-install.ts) to use the new @inkeep/agents-ui-js-cloud@0.15 and @inkeep/agents-ui-cloud packages, consistent with the rest of the migration. No new issues. One item remains pending from the prior review: documenting NEXT_PUBLIC_INKEEP_APP_ID in .env.example.
Discarded (0)
No findings were discarded.
Reviewers (1)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
orchestrator |
0 | 0 | 0 | 0 | 0 | 1 | 0 |
| Total | 0 | 0 | 0 | 0 | 0 | 1 | 0 |
Note: Delta review — the 2 files changed since last review are clean. Only the env var documentation item from prior reviews remains pending.
amikofalvy
left a comment
There was a problem hiding this comment.
@sarah-inkeep do we need to configure the "ship it" chat widget with the new token fetching or is that already being handled?
|
@amikofalvy the chat widget handles the anonymous token fetching internally so it will out of the box unless users are setting up the private / public key and not allowing anonymous sessions, in which case they will need to configure the |
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Inkeep Agent Framework Docs' |

No description provided.