Variable suggestions feature for Prompt/Graph Prompt inputs#438
Merged
robert-inkeep merged 43 commits intoinkeep:mainfrom Oct 2, 2025
Merged
Variable suggestions feature for Prompt/Graph Prompt inputs#438robert-inkeep merged 43 commits intoinkeep:mainfrom
robert-inkeep merged 43 commits intoinkeep:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the Inkeep Team on Vercel. A member of the Team first needs to authorize it. |
dimaMachina
commented
Oct 1, 2025
|
|
||
| .playwright-mcp | ||
| .vercel | ||
| .idea/ |
Collaborator
Author
There was a problem hiding this comment.
to ignore Webstorm settings
dimaMachina
commented
Oct 1, 2025
Comment on lines
+63
to
+65
| </TooltipTrigger> | ||
| <TooltipContent>{expandButtonLabel}</TooltipContent> | ||
| </Tooltip> |
Collaborator
Author
There was a problem hiding this comment.
Added tooltip for full screen icon
dimaMachina
commented
Oct 1, 2025
| <div className="space-y-2"> | ||
| <ExpandableTextArea | ||
| id="graph-prompt" | ||
| name="graph-prompt" |
Collaborator
Author
There was a problem hiding this comment.
unlike textarea, Codemirror editor doesn't have name prop
dimaMachina
commented
Oct 1, 2025
| <ExpandableTextArea | ||
| ref={(el) => setFieldRef('prompt', el)} | ||
| id="prompt" | ||
| name="prompt" |
Collaborator
Author
There was a problem hiding this comment.
unlike textarea, Codemirror editor doesn't have name prop
dimaMachina
commented
Oct 1, 2025
agents-manage-ui/src/components/graph/sidepane/nodes/expandable-text-area.tsx
Outdated
Show resolved
Hide resolved
sarah-inkeep
approved these changes
Oct 2, 2025
Contributor
sarah-inkeep
left a comment
sarah-inkeep
left a comment
There was a problem hiding this comment.
Looks great, work great!
agents-manage-ui/src/components/graph/sidepane/nodes/expandable-text-area.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
22
to
46
| <Tooltip> | ||
| <TooltipTrigger asChild> | ||
| <Button | ||
| variant="ghost" | ||
| size="icon" | ||
| className={cn( | ||
| 'absolute bottom-2.5 h-6 w-6 hover:text-foreground transition-all backdrop-blur-sm bg-white/90 hover:bg-white/95 dark:bg-card dark:hover:bg-accent border border-border shadow-md dark:shadow-lg', | ||
| tooltipClassName | ||
| )} | ||
| type="button" | ||
| onClick={() => { | ||
| codemirrorRef.current.insertTemplateVariable(); | ||
| }} | ||
| > | ||
| <Braces className="h-4 w-4 text-muted-foreground" /> | ||
| <span className="sr-only">{variablesText}</span> | ||
| </Button> | ||
| </TooltipTrigger> | ||
| <TooltipContent> | ||
| {variablesText}{' '} | ||
| <span className="font-mono bg-foreground text-background rounded py-0.5 px-1 ms-1"> | ||
| { } | ||
| </span> | ||
| </TooltipContent> | ||
| </Tooltip> |
Contributor
There was a problem hiding this comment.
yeah I think moving it to prompt-editor sounds good to me but not a strong opinion.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dimaMachina
commented
Oct 2, 2025
agents-manage-ui/src/components/graph/sidepane/nodes/expandable-text-area.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://docs.google.com/document/d/1LdXL3t65yyS2cmOOzphQZNeEtNl37LQriKJgbKMGSfk/edit?tab=t.0
use Codemirror instead simple
<textarea>highlight template variables with different color
suggestion dropdown of variables from
contextVariablesrequestContextSchemanew icon near full screen to add template variables (on full screen mode too)
more tests for
getContextSuggestionsfunctionit now handles all edge cases from https://github.com/inkeep/agents/blob/main/packages/agents-core/src/__tests__/context/validation-edge-cases.test.ts test
error highlightning for unknown variables
