feat: accept any type of range in range assertions#21
Merged
haraldmaida merged 2 commits intoApr 21, 2025
Conversation
…r_count_in_range` assertions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 94.15% 94.05% -0.10%
==========================================
Files 24 24
Lines 2224 2272 +48
Branches 2224 2272 +48
==========================================
+ Hits 2094 2137 +43
- Misses 124 129 +5
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently assertions that take a range as expected value support only
RangeInclusive. This shall be enhanced to support more types of ranges.The assertions
is_in_range,is_not_in_range,has_length_in_rangeandhas_char_count_in_rangehave been changed to support any type of range from the Rust core lib. More precisely, any type that implementscore::ops::RangeBoundsis now supported.