refactor: change signature of methods of AssertCodePanics trait so that …#36
Merged
haraldmaida merged 1 commit intoMay 10, 2025
Conversation
…code assertions can not be chained
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 96.13% 95.92% -0.21%
==========================================
Files 25 25
Lines 2849 2850 +1
Branches 2849 2850 +1
==========================================
- Hits 2739 2734 -5
- Misses 106 112 +6
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…code assertions can not be chained
Assertions whether a closure panics or does not panic can not be chained. A closure can only be asserted once. Currently it is possible to write chained assertions for a closure, but the second assertion panics at runtime.
Instead of a runtime error, a compile time error should be issued, when a chained assertion is written for a closure.
The signature of the methods of the extension trait
AssertCodePanicshave been changed to return aSpecwith a subject of the unit type. It is now longer possible to compile chained assertions for panicking code on closures.