Skip to content

fix!: remove implementation of Default for DoesPanic#37

Merged
haraldmaida merged 3 commits into
mainfrom
fix/remove-default-for-does-panic-expectation
May 10, 2025
Merged

fix!: remove implementation of Default for DoesPanic#37
haraldmaida merged 3 commits into
mainfrom
fix/remove-default-for-does-panic-expectation

Conversation

@haraldmaida
Copy link
Copy Markdown
Member

Currently the expectation DoesPanic implements the Default trait. This supports no sensible usecase and it is not clear what a default DoesPanic expectation is supposed to do.

Remove the implementation of the Default trait for the DoesPanic expectation.

@haraldmaida haraldmaida self-assigned this May 10, 2025
@haraldmaida haraldmaida added the bug Something isn't working label May 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (bd39c80) to head (5117808).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   95.92%   96.04%   +0.11%     
==========================================
  Files          25       25              
  Lines        2850     2854       +4     
  Branches     2850     2854       +4     
==========================================
+ Hits         2734     2741       +7     
+ Misses        112      109       -3     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haraldmaida haraldmaida merged commit 8c91989 into main May 10, 2025
18 checks passed
@haraldmaida haraldmaida deleted the fix/remove-default-for-does-panic-expectation branch May 10, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant