Skip to content

fix: missing #[track_caller] annotations on assertion methods#40

Merged
haraldmaida merged 2 commits into
mainfrom
fix/missing-track-caller-annotations
Jun 2, 2025
Merged

fix: missing #[track_caller] annotations on assertion methods#40
haraldmaida merged 2 commits into
mainfrom
fix/missing-track-caller-annotations

Conversation

@haraldmaida
Copy link
Copy Markdown
Member

Some assertion methods do not have a #[track_caller] annotations. This might result in wrong locations of failing assertions when the assert_that() function is used instead of the assert_that! macro.

Added the #[track_caller] annotation to every assertion method where it was missing.

@haraldmaida haraldmaida self-assigned this Jun 2, 2025
@haraldmaida haraldmaida added the bug Something isn't working label Jun 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (4d7820f) to head (b2c0dcc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files          26       26           
  Lines        2902     2902           
  Branches     2902     2902           
=======================================
  Hits         2789     2789           
  Misses        109      109           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haraldmaida haraldmaida merged commit def3415 into main Jun 2, 2025
18 checks passed
@haraldmaida haraldmaida deleted the fix/missing-track-caller-annotations branch June 2, 2025 07:05
@haraldmaida haraldmaida changed the title fix: missing `#[track_caller] annotations on assertion methods fix: missing #[track_caller] annotations on assertion methods Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant