chore: use the fakeenv crate for testing environment variable specific functionality#50
Merged
haraldmaida merged 1 commit intoJun 8, 2025
Conversation
…fic functionality - crate `serial_test` is no longer needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 96.69% 96.70%
=======================================
Files 30 31 +1
Lines 3416 3425 +9
Branches 3416 3425 +9
=======================================
+ Hits 3303 3312 +9
Misses 109 109
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing code that makes decisions based on the value of environment variables faces two problems:
std::env::set_varandstd::env::remove_varare unsafe on some operating systemsFor the first problem we used the
serial_testcrate to mark all tests that shall not run in parallel.Using a fake "environment", that mimics the related functions from the
std::envmodule, for testing solves both problems. The crateserial_testis no longer needed as a dependency.Refactored tests in
colored::testsmodule to use a fake environment and removed theserial_testdependency.