feat!: implement Not expectation combinator and revise failure messages#52
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
- Coverage 96.70% 95.71% -0.99%
==========================================
Files 31 31
Lines 3425 3899 +474
Branches 3425 3899 +474
==========================================
+ Hits 3312 3732 +420
- Misses 109 118 +9
- Partials 4 49 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Not expectation combinator and revise failure messagesNot expectation combinator and revise failure messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a "not" combinator for expectations makes writing (custom) assertions more convinient.
Implemented the
Notexpectation combinator and adapted all implementations of currently provided expectations to make use of theNotcombinator if feasible.Additionally revised all failure messages mainly changing the phrases "is" or "has" to "to be" or "to have".
BREAKING CHANGES:
Expectation::message()is changed. The methodmessage()has got the additional argumentinverted: boolwhich is set when an expectation has been inverted with theNotcombinator expectation.