Merged
Conversation
kofrezo
requested changes
Mar 6, 2026
Contributor
kofrezo
left a comment
kofrezo
left a comment
There was a problem hiding this comment.
Nice! Just some minor changes needed 👍
| autocomplete_search_input.autocomplete('enable'); | ||
| autocomplete_search_input.autocomplete('option', 'autoFocus', $('#autoselect')[0].checked); | ||
| autocomplete_search_input.autocomplete('option', 'minLength', 0); | ||
| autocomplete_search_input.autocomplete('option', 'delay', 50); |
Contributor
There was a problem hiding this comment.
Can we use the delay as well from the search settings ?
Contributor
Author
There was a problem hiding this comment.
I initially also thought about this, but i tought its not necessary since we only hit agains local storage.
So we can query it pretty much how often we like, which makes the UI as snappy as possible.
Contributor
There was a problem hiding this comment.
The delay is not in there because of the network traffic but because users got annoyed by the search kicking in too fast.
kofrezo
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed solution for #432
I would be happy for feedback :D