PR from coreui-react origin master #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- toggling sidebar state internally through context, - delete tag and type props - clean component
- render nodes, even if there are no children, - delete 'tag' from divider and title - clean components
- replace 'variant' prop with 'grow' - replace sr-only tag with aria-attributes - clean component
- delete props which are not controlled HTML attributes - rename 'onChange' to 'onCheckedUpdate' - fix wrong classes - pass attributes and ref to input - fix PropTypes and default values - delete obsolete props
- fix: CDataTable - set perPageItems select box, pagination - update: CPagination with pages prop (more important than maxPage)
- add missing className, cssModules, - dropdownSlot to footerSlot, - delete mainText prop - clean component
# Conflicts: # src/CBreadcrumb.js # src/CCollapse.js # src/CDropdown.js
- CToast: delete 'header', 'headerSlot', 'custom', 'transition' props fix animation, allow for cancelling autohide when it starts hidding, correct animation times, add 'onStateChange' prop - CToastHeader - add default closing button - delete tag prop from components, clean comopnents
fix(CDataTable): correct itemsPerPageSelect padding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.