Conversation
guilfb
left a comment
There was a problem hiding this comment.
Hi Pierre,
I am soooo happy to see this project emerging right now (and of course always a pleasure to hear you on video 😉).
I have to say that this is a very very very good first PR on this project.
We can feel that you have done a very comprehensive study on what is currently being done in some other open source projects, and you selected only the interesting parts for our use case.
It really is an amazing job.
I did have questions on some choices that you made, and also some improvements to handle different hardware / local configurations.
Can't wait to hear your feedbacks on my questions / remarks !
Again, greaaat job Pierre thank you very much!
Gui
- Development Setup (editorconfig, precommit, mkdocs) in CONTRIBUTING.md - CONTRIBUTING link in PULL_REQUEST_TEMPLATE.md - CONTRIBUTING & LICENSE links in README.md
|
@guilfb I've applied your feedback, you can do a quick check of the commits made since then. ;) |
|
Seems wonderful to me, great job again @pierrocknroll, thank you! |
This PR is described in this video :
https://www.loom.com/share/9923b5155eec4ad8b1825d1edbbe93b5?sid=0dbcd9fc-ca25-44d3-ac26-10df9a2e272e
The 5 minute limit cut me off to say that I put an init file in the src folder so that the folder exists in the project (I don't really like .gitkeep files because they're not official).
And I've also put a conftest file so that the tests folder exists.
I forgot to mention that in the CONTRIBUTING section I explain some of the best practices we've chosen together, in particular the use of docstring in Google format.
The issue creation will look like this:

Sources :
Github files :
Doc files :
Python projects :
Norms and tools: