feat: Expanded drep_state with historical state and rollback support #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
golddydev
reviewed
Aug 21, 2025
golddydev
reviewed
Aug 21, 2025
golddydev
approved these changes
Aug 22, 2025
Collaborator
golddydev
left a comment
golddydev
left a comment
There was a problem hiding this comment.
this looks fine to me.
sandtreader
reviewed
Aug 25, 2025
sandtreader
reviewed
Aug 25, 2025
| } | ||
|
|
||
| pub async fn init(&self, context: Arc<Context<Message>>, config: Arc<Config>) -> Result<()> { | ||
| fn get_bool_flag(config: &Config, key: (&str, bool)) -> bool { |
Collaborator
There was a problem hiding this comment.
Feels like these could go in a common/config helper?
sandtreader
reviewed
Aug 25, 2025
sandtreader
approved these changes
Aug 25, 2025
Collaborator
sandtreader
left a comment
sandtreader
left a comment
There was a problem hiding this comment.
Great stuff - only comment is whether we should define a hash type.
Collaborator
|
Merged but left branch open in case you want to do the hash type |
buddhisthead
pushed a commit
that referenced
this pull request
Oct 10, 2025
…pansion feat: Expanded drep_state with historical state and rollback support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the
drep_statemodule to support all state data needed to align with all /governance/dreps/ related Blockfrost endpoints. A follow up PR will wire these endpoints to the newhistorical_drepsdata.Main changes:
HistoricalDRepStatekeyed byDRepCredentialstoring:tx_hashandcert_index)StateHistoryto commit state changes by block, enabling rollback support.cardano.governance(for votes whenstore-votesenabled)cardano.protocol.parameters(for drep expiration tracking whenstore-infoenabled)GovernanceProceduresMessageto includevote_indexin eachVotingProcedure.DRepRegistration,DRepDeregistration, andDRepUpdatetypes ofTxCertificatewithtx_hashandcert_index.This implementation makes storage configurable within the module so users can keep resource costs low when DRep data isn't needed.