Shd/better governance logs #231
Closed
+1,090
−333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shd
commented
Oct 7, 2025
shd
commented
- Prints various logs about Conway governance
- Fixes bugs in Conway governance
- A simple test comparing logs with dbsync output added
sandtreader
reviewed
Oct 22, 2025
| self.conway.as_ref().ok_or_else(|| anyhow!("Conway parameters not available")) | ||
| } | ||
|
|
||
| pub fn update_parameters(&mut self, conway: &Option<ConwayParams>, bootstrap: bool) { |
There was a problem hiding this comment.
Handy to note what 'bootstrap' means here = Chang era (took me a while to work this out, not knowing the history)
sandtreader
reviewed
Oct 22, 2025
| } | ||
|
|
||
| pub fn log_conway_voting_stats(&self) { | ||
| info!("*** Current voting stats: ***"); |
There was a problem hiding this comment.
Not keen on shouty logs personally ;-)
|
Happy to go ahead but needs some conflict resolution, sorry! Actual effect of this is to implement different vote handling in Chang, I think - would be good to note that in the summary. |
This was referenced Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.