feat: address totals REST endpoint #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nting txs Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
…x entries Signed-off-by: William Hankins <william@sundae.fi>
whankinsiv
changed the title
Signed-off-by: William Hankins <william@sundae.fi>
…cessed Signed-off-by: William Hankins <william@sundae.fi>
lowhung
approved these changes
Nov 12, 2025
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_same_tx_deltas_sums_totals_in_volatile() -> Result<()> { |
| ) | ||
| .await?; | ||
|
|
||
| // TODO: Query historical accounts state to retrieve account tx count instead of |
Collaborator
There was a problem hiding this comment.
Good TODO / comment here.
golddydev
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
/addresses/{address}/totaland/accounts/{stake_address}/totalendpoints. It also refactorsapply_address_deltasto fix a bug that overcounted total transaction counts for address UTxO deltas within the same transaction.Related Issue(s)
#256 & #335
How was this tested?
ValueDeltavalues summed correctly.Checklist
Impact / Side effects
No major side effects. Converting
ValueDeltatoValueDeltaMapbefore summing same addresssame transaction UTxO deltas adds a minor performance cost, but fixes overcounting.
Note: total tx count for the accounts version of this endpoint will need to be persisted in
historical_accounts_state, since summing address counts overestimates totals for multi-address transactions. This will be implemented in a follow up PR.Reviewer notes / Areas to focus
apply_address_deltasinmodules/address_state/src/state.rs. Considering a potential refactor of the upstreamAddressDeltaspublisher inutxo_stateto pre aggregate deltas by transaction before publishing.