refactor: group UTxO and address deltas by tx #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
SupernaviX
reviewed
Nov 13, 2025
| pub received_sum: AmountList, | ||
| pub sent_sum: AmountList, | ||
| pub tx_count: u64, | ||
| pub tx_count: u32, |
Collaborator
There was a problem hiding this comment.
I wonder how many centuries Cardano will need to exist for, before an account is affected by a 4,294,967,296th transaction and makes this endpoint fail
SupernaviX
reviewed
Nov 13, 2025
Comment on lines
2157
to
2161
| #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)] | ||
| pub struct TxTotals { | ||
| pub sent: ValueDelta, | ||
| pub received: Value, | ||
| } |
Collaborator
There was a problem hiding this comment.
Why is sent a ValueDelta but received a Value? It looks like in at least a few places, we assume that sent.lovelace is positive.
(also, it might make some code a little cleaner if TxTotals had an as_delta helper method which returned its data as a ValueDelta)
Collaborator
Author
There was a problem hiding this comment.
Thanks for catching this Simon. I had assumed ValueDelta was needed downstream but this isn't the case. I've updated TxTotals and AddressTotals to use Value for the sent field in df09d6f.
lowhung
approved these changes
Nov 13, 2025
|
|
||
| for result in self.tx_count.prefix(account.get_hash().as_ref()) { | ||
| let (_, bytes) = result?; | ||
| let epoch_count = u32::from_le_bytes(bytes[..4].try_into()?); |
| store-spdd = false | ||
|
|
||
| [module.historical-accounts-state] | ||
| # Enables /accounts/{stake_address}/rewards endpoint |
Signed-off-by: William Hankins <william@sundae.fi>
SupernaviX
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors both
UTXODeltasMessageandAddressDeltasMessageto group deltas per transaction instead of per individual UTxO delta. This fixes incorrect transaction counting in bothaddress_stateandhistorical_accounts_state, particularly in cases where:Account level transaction counting is now handled separately in
historical_accounts_state, avoiding the need to indexTxIdentifiervalues by address. A newGetAccountTotalTxCountquery is added to support the/accounts/{stake_address}/addresses/totalendpoint.Related Issue(s)
How was this tested?
/accounts/{stake_address}/addresses/totalsto confirm that tx counts now match expected behavior.Checklist
Impact / Side effects
utxo_stateconstructs a temporaryAddressTxMapper transaction to aggregate UTxO deltas before publishing address level deltas.StakeDeltasMessagenow includes the per block tx count in the delta.Reviewer notes / Areas to focus
tx_unpacker/src/tx_unpacker.rshandleinutxo_state/src/state.rsprocess_messageinstake_delta_filter/src/utils.rs