Sg/preview sanchonet fixes #359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes several issues I ran into when trying to replace upstream-chain-fetcher with peer-network-interface.
PeerNetworkInterfacewasn't consistently settingnew_epochtotruecorrectly. It was checking if the current slot was the first slot in an epoch, but that is not a reliable detection method because there's no guarantee a block will always be created in that slot. Switch to computing this by tracking the last epoch we reported instead.parameter_stateto download and bundle preview genesis config values. This lets us run more of the system against preview values.utxo_statewhere the module assumed it never processed block 0.How was this tested?
I ran omnibus with both the sanchonet and preview configurations. It doesn't make it past epoch 2 on either, but it makes it farther than before.
Checklist
Impact / Side effects
The omnibus preview/sanchonet configurations now actually do something, instead of just spewing blocks into nothingness.
Reviewer notes / Areas to focus