feat: implement /epochs/{number}/blocks endpoint
#366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whankinsiv
reviewed
Nov 18, 2025
lowhung
approved these changes
Nov 18, 2025
| block = make_rolled_back_block(0); | ||
| let mut state = history.lock().await.get_rolled_back_state(block.number); | ||
| state.handle_mint(&block, b"issuer_2"); | ||
| state.handle_mint(&block, Some(b"issuer_2")); |
Collaborator
There was a problem hiding this comment.
nit: do we want a case where there isn't an the issuer_vkey is None?
whankinsiv
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
/epochs/{number}/blocksendpoint usingchain_storemodule.Changes
GetBlockHashesByNumberRangequery to block query enumRelated Issue(s)
Closes #185
How was this tested?
Tested with omnibus process
Checklist
Impact / Side effects
No
Reviewer notes / Areas to focus
chain_store.rsNote
For now
/epochs/{number}/blocksis missing one block hash (EBB) since we don't handle EBB.