feat: replace UpstreamChainFetcher with PeerNetworkInterface #367
+26
−938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowhung
reviewed
Nov 18, 2025
lowhung
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces all uses of
UpstreamChainFetcherwithPeerNetworkInterface.The two modules serve similar purposes, the main difference is that PeerNetworkInterface can connect to multiple peers and switch between them as needed. PeerNetworkInterface is also better able to handle rollback, and is robust to upstream issues (if we get any errors from a peer, we reconnect to them later and switch to another peer)
Related Issue(s)
Followup to #204
How was this tested?
With great difficulty.
I ran Acropolis' sanchonet configuration using
PeerNetworkInterfaceandUpstreamChainFetcher, and confirmed that I got the same series of errors and failures.Checklist
Impact / Side effects
No negative impacts. Chainsync is more robust to network flakiness or logic errors now.