-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Add dynamic sync mode to peer_network_interface #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+384
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
SupernaviX
reviewed
Nov 20, 2025
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
SupernaviX
approved these changes
Nov 21, 2025
lowhung
approved these changes
Nov 24, 2025
sandtreader
approved these changes
Nov 25, 2025
Collaborator
sandtreader
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice, and I agree with all of Simon's tweaks. I like the forward thinking for subsequent commands from consensus and the simplicity of the demo indexer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
dynamicsync mode to thepeer_network_interface. In this mode, the interface waits for aChangeSyncPointcommand on thecardano.sync.commandtopic and begins fetching from that point.A background task forwards incoming sync points to the
NetworkManager. When a new point arrives, the manager resets theChainState, clears outstanding peer requests, and issues a newfind_intersectacross all upstream peers.A minimal
indexerprocess is included to demonstrate this behavior. It registers only the required modules and emits twoChangeSyncPointcommands 5 seconds apart, demonstrating dynamic re-syncing.Related Issue(s)
#374
How was this tested?
By running the
indexerprocess:peer_network_interfacebegins fetching blocks normally.ChangeSyncPointis published, returning to the starting point.peer_network_interfaceresets and syncs again from that point.For visibility, you can log inside
handle_roll_forwardto observe block fetching.Checklist
Impact / Side effects
Adds a basic
indexerprocess intended to become the minimal working example for building custom indexers on top of Acropolis.Reviewer notes / Areas to focus
NetworkManagerconstruction inpeer_network_interface/src/peer_network_interface.rs.on_sync_cmdwhen resetting sync state inpeer_network_interface/src/network.rs.