Add intent field to BlockInfo #412
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandtreader
reviewed
Nov 24, 2025
Collaborator
sandtreader
left a comment
sandtreader
left a comment
There was a problem hiding this comment.
Looks good - only comment is whether intent in validator tests ought to set Validate, because once intent is taken account of, they will only operate when it is set.
| hex::decode(include_str!("./data/7854823.cbor")).unwrap(); | ||
| let block_info = BlockInfo { | ||
| status: BlockStatus::Immutable, | ||
| intent: BlockIntent::Apply, |
Collaborator
There was a problem hiding this comment.
Given this is a validator, shouldn't this be BlockIntent::Validate?
| hex::decode(include_str!("./data/4490511.cbor")).unwrap(); | ||
| let block_info = BlockInfo { | ||
| status: BlockStatus::Immutable, | ||
| intent: BlockIntent::Apply, |
|
|
||
| let block_info = BlockInfo { | ||
| status: BlockStatus::Immutable, | ||
| intent: BlockIntent::Apply, |
Collaborator
There was a problem hiding this comment.
Originally thought this should be configurable but actually it will be consensus which sets the Validate bit if it wants to, so this is fine as is.
lowhung
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new field to BlockInfo - intent. This signals whether the block should be just validated, just applied or both.
Related Issue(s)
Relates to #397.
How was this tested?
The only test for this change is that it doesn't break anything, so this was tested using existing unit tests and by running the service to make sure it still functions.
Checklist
Impact / Side effects
When creating new blocks the intent field must be set.
Reviewer notes / Areas to focus
Nothing specific.