diff-containers: Simplify the DiffHistory and NEDiffHistory types
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
changed the title
DiffHistory and NEDiffHistory typesdiff-containers: Simplify the DiffHistory and NEDiffHistory types
7 tasks
The current definitions are too verbose, and unnecessarily generalised. This commit simplifies the definitions at no cost to the functionality.
jorisdral
force-pushed
the
jdral/diff-containers-simplify-diff-history-type
branch
from
c2ee233 to
240ed9d
Compare
jasagredo
reviewed
Feb 1, 2023
dnadales
reviewed
Feb 1, 2023
dnadales
approved these changes
Feb 1, 2023
jorisdral
deleted the
jdral/diff-containers-simplify-diff-history-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current definitions are too verbose, and unnecessarily generalised. This commit simplifies the definitions at no cost to the functionality.