diff-containers: Remove Values and Keys newtypes, use Map and Set instead
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
changed the title
diff-containers: remove unnecessary Values and Keys newtypes, use Map and Set insteaddiff-containers: remove Values and Keys newtypes, use Map and Set instead
jorisdral
changed the title
diff-containers: remove Values and Keys newtypes, use Map and Set insteaddiff-containers: Remove Values and Keys newtypes, use Map and Set instead
7 tasks
jorisdral
deleted the
jdral/diff-containers-remove-unnecessary-newtypes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ValuesandKeysnewtypes areourboros-consensusspecific, so we should use the more widely usedMapandSettypes instead. This makes thediff-containerspackage more general purpose.