lw-7089: fix trezor transaction mismatching issue #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomislavhoracek
requested review from
AngelCastilloB,
DominikGuzei,
marcin-mazurek and
rhyslbw
tomislavhoracek
temporarily deployed
to
dev-preview
GitHub Actions
Inactive
tomislavhoracek
changed the base branch from
master
to
chore/lw-6514-hardware-trezor-package
…-trezor-tx-hash-mismatching-issue
DominikGuzei
approved these changes
Aug 22, 2023
Member
DominikGuzei
left a comment
DominikGuzei
left a comment
There was a problem hiding this comment.
Nice work 🎉 so the problem was just bad test code?
Contributor
Author
yeah :( |
…-trezor-tx-hash-mismatching-issue
Contributor
Author
|
@DominikGuzei @AngelCastilloB Can you check the last commit d045670 please? 🙏 |
marcin-mazurek
approved these changes
Aug 24, 2023
mkazlauskas
approved these changes
Aug 24, 2023
AngelCastilloB
approved these changes
Aug 24, 2023
marcin-mazurek
deleted the
fix/lw-7089-trezor-tx-hash-mismatching-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces a fix for the Trezor transaction hash mismatching issue
Proposed Solution
The Trezor transaction hash must always match the one originating from Cardano JS SDK, otherwise transaction submission will fail.
Important Changes Introduced