-
Notifications
You must be signed in to change notification settings - Fork 1
feat(rust/cardano-chain-follower): RBAC CIP509 validation #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenj
requested changes
Sep 13, 2024
* test(rust/cardano-chain-follower): add test data * test(rust/cardano-chain-follower): add test for x509_chunk decompression * fix(rust/cardano-chain-follower): payment key should accept negative number * test(rust/cardano-chain-follower): add test for cip509 validation * chore(rust/cardano-chain-follower): typo * fix(rust/cardano-chain-follower): update test data
stevenj
approved these changes
Sep 17, 2024
Collaborator
stevenj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CIP509 RBAC Validation
Move from input-output-hk/hermes#351
Related Issue(s)
Closes #324
Description of Changes
The validation includes
0: transaction inputswithin the transaction should match the1: txn-inputs-hash?7: auxiliary_data_hashshould match the hash of the auxiliary data. This also log the pre-hashed of the auxiliary data (aux with99: validation signatureset to 0x00`)?3: payment-keyValidation Logging
If validation report is not empty (meaning there is some error) log the error
e.g.
CIP509 4: ["Failed to compare public keys with witnesses No public key addresses provided"], chain: "Preprod"else logging the actual validation mention above
e.g.
Please confirm the following checks