Skip to content

Conversation

@bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Sep 16, 2024

Description

Add test for CIP509 RBAC validation

Related Issue(s)

Closes #20

Description of Changes

Test Data

  • Include test data from a real conway block
  • Readme is provided for the test data

Test include

  • Decoding CIP509 cbor
  • Validate txn input hash
  • Validate aux hash
  • Validate stake public key (exist + not exist)
  • Validate payment key reference (positive + negative references)
  • Decompression for Raw, Brotli, and Zstd

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn marked this pull request as draft September 16, 2024 02:23
@bkioshn bkioshn self-assigned this Sep 16, 2024
@bkioshn bkioshn added the enhancement New feature or request label Sep 16, 2024
@bkioshn bkioshn marked this pull request as ready for review September 16, 2024 09:55
@bkioshn bkioshn added the review me PR is ready for review label Sep 16, 2024
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin merged commit af7a84d into feat/rbac-validation Sep 16, 2024
@minikin minikin deleted the test/rbac-validation branch September 16, 2024 16:07
stevenj added a commit that referenced this pull request Sep 17, 2024
* feat: move rbac validate from hermes

* fix: change tx index to u16

* fix: rust ci branch pointing

* fix: update rust ci version

* fix(rust/cardano-chain-follower): move chain follower commands to itss on justfile

* fix(rust/c509-certificate): only extract stake key for pubkey validation

* fix(rust/c509-certificate): spelling

* fix(rust/c509-certificate): stake public key validation + test cases

* fix(rust/c509-certificate): ignore format for cspell addresses

* fix(rust/c509-certificate): disable cspell check for addresses

* fix(rust/cardano-chain-follower): payment key ref index

* fix(rust/cardano-chain-follower): payment key ref index type to i16

* test(rust/cardano-chain-follower): CIP509 RBAC validation (#25)

* test(rust/cardano-chain-follower): add test data

* test(rust/cardano-chain-follower): add test for x509_chunk decompression

* fix(rust/cardano-chain-follower): payment key should accept negative number

* test(rust/cardano-chain-follower): add test for cip509 validation

* chore(rust/cardano-chain-follower): typo

* fix(rust/cardano-chain-follower): update test data

---------

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants