Skip to content

Conversation

@apskhem
Copy link
Collaborator

@apskhem apskhem commented Dec 9, 2025

Description

  • Removed the code inside DocumentOwnershipRule where it can cause panic during validation, especially when the Provider is empty.

Related Issue(s)

Resolves #3831

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Dec 9, 2025
@apskhem apskhem added this to Catalyst Dec 9, 2025
@apskhem apskhem added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Dec 9, 2025
@apskhem apskhem moved this from New to 👀 In review in Catalyst Dec 9, 2025
@apskhem apskhem requested review from Mr-Leshiy, saibatizoku and stanislav-tkach and removed request for stanislav-tkach December 9, 2025 13:58
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/fix/ownership-rule-validation

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Test Report | ${\color{lightgreen}Pass: 605/605}$ | ${\color{red}Fail: 0/605}$ |

@github-project-automation github-project-automation bot moved this from 👀 In review to 🔖 Ready in Catalyst Dec 10, 2025
@apskhem apskhem moved this from 🔖 Ready to 👀 In review in Catalyst Dec 10, 2025
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 3410a5c into main Dec 10, 2025
23 checks passed
@Mr-Leshiy Mr-Leshiy deleted the fix/ownership-rule-validation branch December 10, 2025 07:54
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

PUT v1/document 500 error response

3 participants