feat(rust/rbac-registration): RBAC registration #85

bkioshn · 2024-11-19T07:49:42Z

Description

Create a RBAC registration library

Related Issue(s)

Closes #87

Description of Changes

Create a RBAC registration lib
Move CIP509 and its validation from cardano-chain-follower

Please confirm the following checks

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream module

Signed-off-by: bkioshn <bkioshn@gmail.com>

github-actions · 2024-11-29T07:26:54Z

✅ Test Report | ${\color{lightgreen}Pass: 253/253}$ | ${\color{red}Fail: 0/253}$ |

* feat: add cardano registration chain Signed-off-by: bkioshn <bkioshn@gmail.com> * feat: add wrapper to registration chain inner Signed-off-by: bkioshn <bkioshn@gmail.com> * fix: format Signed-off-by: bkioshn <bkioshn@gmail.com> * fix: comment Signed-off-by: bkioshn <bkioshn@gmail.com> * fix: signing and encryption key Signed-off-by: bkioshn <bkioshn@gmail.com> * chore: fix format Signed-off-by: bkioshn <bkioshn@gmail.com> * fix: move struct to its own file and private the inner regis Signed-off-by: bkioshn <bkioshn@gmail.com> --------- Signed-off-by: bkioshn <bkioshn@gmail.com>

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: payment key shelley address and add test for registration chain Signed-off-by: bkioshn <bkioshn@gmail.com> * chore: comment * fix: format * fix: use ShelleyPaymentPart Signed-off-by: bkioshn <bkioshn@gmail.com> * fix: track ShelleyAddress Signed-off-by: bkioshn <bkioshn@gmail.com> * fix: remove tracking_payment_key and use tracking_payment_history Signed-off-by: bkioshn <bkioshn@gmail.com> --------- Signed-off-by: bkioshn <bkioshn@gmail.com> Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>

stevenj

LGTM

bkioshn added 10 commits November 10, 2024 07:14

feat: move cip509 from cardano chain follower

a1b0db1

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: remove key ref and use key local ref

05c5ae3

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: structure of x509, c509, and public key

7f502ca

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: validation

becf775

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: update x509 and c509 certs

a65cba4

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: key local ref

94dcefc

fix: c509 cert

2c5c077

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: to string

33d1ad3

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: rearrange utils

f083502

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: cargo toml

890689d

Signed-off-by: bkioshn <bkioshn@gmail.com>

bkioshn marked this pull request as draft November 19, 2024 07:49

bkioshn added 8 commits November 25, 2024 10:59

fix: add new type + comment

b92ecd4

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: linter

c04eca4

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: smart pointer

b874c3e

Signed-off-by: bkioshn <bkioshn@gmail.com>

chore: fix format

89f627a

Signed-off-by: bkioshn <bkioshn@gmail.com>

Merge branch 'main' into feat/rbac-registration

d1181dd

fix: cleanup cargo.toml

c90e0ee

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: add rbac-registration to earthly rust

2777246

fix: move cip509 validation

8fae2f0

Signed-off-by: bkioshn <bkioshn@gmail.com>

bkioshn changed the title ~~Feat/rbac registration~~ feat: RBAC registration Nov 26, 2024

fix: rust ci

8aba254

Signed-off-by: bkioshn <bkioshn@gmail.com>

bkioshn changed the title ~~feat: RBAC registration~~ feat(rbac-registration): RBAC registration Nov 26, 2024

bkioshn and others added 8 commits November 26, 2024 14:44

feat: add role signing key validation

d84aee0

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: add Bytes conversion for Pubkey

86c163f

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: error return

afcaa09

fix: use Hash from pallas for tx hash

76b20ca

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: format

99d8a86

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: bytes to pubkey conversion

72a1d3a

fix: add Bytes conversion for Pubkey

bb43028

Signed-off-by: bkioshn <bkioshn@gmail.com>

Merge branch 'main' into feat/rbac-registration

ecaf37e

fix: add rbac-reg to semantic pull request

7583aec

bkioshn changed the title ~~feat(rbac-registration): RBAC registration~~ feat(rust/rbac-registration): RBAC registration Nov 27, 2024

bkioshn and others added 11 commits November 29, 2024 11:45

fix: test data

5571d1a

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: signing and encryption key

3a9f170

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: format

6cb3b8d

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: witness test data to be compatible with new test data

7e8ec2d

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: validate stake public key witness and add test for role signing key

4a07cae

Signed-off-by: bkioshn <bkioshn@gmail.com>

chore: doc about context specific

f10c230

Signed-off-by: bkioshn <bkioshn@gmail.com>

Merge branch 'main' into feat/rbac-registration

3d4ff45

chore: fix format

00fa07d

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: remove test since cip509 decode are done in validation test

eea1afa

fix: test

6da8f96

fix: test compression data

a1cea39

Signed-off-by: bkioshn <bkioshn@gmail.com>

bkioshn added the enhancement New feature or request label Nov 29, 2024

bkioshn marked this pull request as ready for review November 29, 2024 07:55

bkioshn and others added 4 commits November 29, 2024 21:35

fix: remove txn index and change test data to chain root

ccfd89e

Signed-off-by: bkioshn <bkioshn@gmail.com>

chore: fix comment

6356c44

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: remove tx index from cip-509 validate function

efb04e4

Signed-off-by: bkioshn <bkioshn@gmail.com>

bkioshn added the do not merge yet PR is not ready to be merged yet label Dec 2, 2024

bkioshn and others added 6 commits December 2, 2024 13:48

fix: test data

b97a095

Signed-off-by: bkioshn <bkioshn@gmail.com>

chore: fix format

d0bf563

fix: remove txn index from validate

18ea3aa

Signed-off-by: bkioshn <bkioshn@gmail.com>

fix: format

3479ed4

Merge branch 'main' into feat/rbac-registration

8cbe99d

stevenj approved these changes Dec 2, 2024

View reviewed changes

stevenj merged commit 149bf11 into main Dec 2, 2024
24 checks passed

stevenj deleted the feat/rbac-registration branch December 2, 2024 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(rust/rbac-registration): RBAC registration #85

feat(rust/rbac-registration): RBAC registration #85

Uh oh!

bkioshn commented Nov 19, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 29, 2024 •

edited

Loading

Uh oh!

stevenj left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(rust/rbac-registration): RBAC registration #85

feat(rust/rbac-registration): RBAC registration #85

Uh oh!

Conversation

bkioshn commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Description of Changes

Please confirm the following checks

Uh oh!

github-actions bot commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stevenj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bkioshn commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 29, 2024 •

edited

Loading