Skip to content

Conversation

@bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Nov 26, 2024

Description

Implement cardano RBAC registration chain

Related Issue(s)

Closes #88

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Signed-off-by: bkioshn <bkioshn@gmail.com>
@bkioshn bkioshn marked this pull request as draft November 26, 2024 14:22
@bkioshn bkioshn self-assigned this Nov 26, 2024
@bkioshn bkioshn changed the title feat: add cardano registration chain feat(rust/rbac-registration): add cardano registration chain Nov 27, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024

Test Report | ${\color{lightgreen}Pass: 248/248}$ | ${\color{red}Fail: 0/248}$ |

Signed-off-by: bkioshn <bkioshn@gmail.com>
@bkioshn bkioshn marked this pull request as ready for review November 29, 2024 07:52
@bkioshn bkioshn added the enhancement New feature or request label Nov 29, 2024
Signed-off-by: bkioshn <bkioshn@gmail.com>
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 39ff437 into feat/rbac-registration Nov 29, 2024
24 checks passed
@stevenj stevenj deleted the feat/registration-chain branch November 29, 2024 14:35
stevenj added a commit that referenced this pull request Dec 2, 2024
* feat: move cip509 from cardano chain follower

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: remove key ref and use key local ref

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: structure of x509, c509, and public key

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: validation

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: update x509 and c509 certs

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: key local ref

* fix: c509 cert

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: to string

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: rearrange utils

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: cargo toml

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: add new type + comment

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: linter

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: smart pointer

Signed-off-by: bkioshn <bkioshn@gmail.com>

* chore: fix format

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: cleanup cargo.toml

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: add rbac-registration to earthly rust

* fix: move cip509 validation

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: rust ci

Signed-off-by: bkioshn <bkioshn@gmail.com>

* feat: add role signing key validation

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: add Bytes conversion for Pubkey

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: error return

* fix: use Hash from pallas for tx hash

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: format

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: bytes to pubkey conversion

* fix: add Bytes conversion for Pubkey

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: add rbac-reg to semantic pull request

* fix: test data

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: signing and encryption key

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: format

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: witness test data to be compatible with new test data

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: validate stake public key witness and add test for role signing key

Signed-off-by: bkioshn <bkioshn@gmail.com>

* chore: doc about context specific

Signed-off-by: bkioshn <bkioshn@gmail.com>

* chore: fix format

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: remove test since cip509 decode are done in validation test

* fix: test

* fix: test compression data

Signed-off-by: bkioshn <bkioshn@gmail.com>

* feat(rust/rbac-registration): add cardano registration chain (#90)

* feat: add cardano registration chain

Signed-off-by: bkioshn <bkioshn@gmail.com>

* feat: add wrapper to registration chain inner

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: format

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: comment

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: signing and encryption key

Signed-off-by: bkioshn <bkioshn@gmail.com>

* chore: fix format

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: move struct to its own file and private the inner regis

Signed-off-by: bkioshn <bkioshn@gmail.com>

---------

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: remove txn index and change test data to chain root

Signed-off-by: bkioshn <bkioshn@gmail.com>

* chore: fix comment

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: remove tx index from cip-509 validate function

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: test data

Signed-off-by: bkioshn <bkioshn@gmail.com>

* chore: fix format

* fix: remove txn index from validate

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: format

* fix(rust/rbac-registration): Tracking payment key type (#93)

* fix: payment key shelley address and add test for registration chain

Signed-off-by: bkioshn <bkioshn@gmail.com>

* chore: comment

* fix: format

* fix: use ShelleyPaymentPart

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: track ShelleyAddress

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: remove tracking_payment_key and use tracking_payment_history

Signed-off-by: bkioshn <bkioshn@gmail.com>

---------

Signed-off-by: bkioshn <bkioshn@gmail.com>
Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>

---------

Signed-off-by: bkioshn <bkioshn@gmail.com>
Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants