Skip to content

Update EVM block timestamp params #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saibatizoku merged 3 commits into from
Mar 2, 2022
Merged

Update EVM block timestamp params #751

saibatizoku merged 3 commits into from
Mar 2, 2022

Conversation

@saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Feb 17, 2022

Uses the BlockDate and ledger settings such as slots_per_epoch, and slot_duration, as well as the Block0Date value to calculate the appropriate timestamp each time apply_block is called.

@saibatizoku saibatizoku self-assigned this Feb 17, 2022
@saibatizoku saibatizoku force-pushed the update-evm-env-timestamp branch from e60d21b to 7445909 Compare February 18, 2022 03:31
@saibatizoku saibatizoku marked this pull request as ready for review February 18, 2022 03:31
@saibatizoku saibatizoku force-pushed the update-evm-env-timestamp branch from 7445909 to 0b165fc Compare February 18, 2022 03:52
zeegomo
zeegomo reviewed Feb 18, 2022
View reviewed changes
Mr-Leshiy
Mr-Leshiy reviewed Feb 22, 2022
View reviewed changes
@saibatizoku saibatizoku force-pushed the update-evm-env-timestamp branch 2 times, most recently from 13bd275 to d177046 Compare February 23, 2022 07:23
@saibatizoku saibatizoku force-pushed the update-evm-env-timestamp branch from d177046 to 35ae0a4 Compare February 23, 2022 13:49
@minikin
Copy link
Contributor

minikin commented Mar 2, 2022

@saibatizoku @Mr-Leshiy
Can we resolve issues here to merge it, please? Or do we have some other dependencies ?

@saibatizoku saibatizoku force-pushed the update-evm-env-timestamp branch from 35ae0a4 to 4379d47 Compare March 2, 2022 15:34
@saibatizoku
Copy link
Contributor Author

saibatizoku commented Mar 2, 2022

@saibatizoku @Mr-Leshiy Can we resolve issues here to merge it, please? Or do we have some other dependencies ?

I'm rebasing to master, cleaning lints and running thru the CI for merging.

@saibatizoku saibatizoku force-pushed the update-evm-env-timestamp branch from 4379d47 to b234374 Compare March 2, 2022 15:46
@saibatizoku saibatizoku merged commit 2245510 into master Mar 2, 2022
@saibatizoku saibatizoku deleted the update-evm-env-timestamp branch March 2, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

+1 more reviewer

@zeegomo zeegomo zeegomo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saibatizoku saibatizoku

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saibatizoku @minikin @Mr-Leshiy @zeegomo