Skip to content

Conversation

@michalrus
Copy link
Member

@michalrus michalrus commented May 11, 2023

This PR updates Electron and Node.js.

Direct trigger was our need for the node:crypto built-in module, which was not available in Node.js 14.×, but it's good to update either way.

Also: all Windows blobs are now cross-built from source (still with Visual Studio).

Todos

  • Linux
  • macOS on Intel
  • macOS on Apple Silicon
  • Windows
  • Linux devshell
  • macOS devshell

Screenshots

n/a

Testing Checklist

  • Slack QA thread
  • Please, test hardware wallets
  • And also that opening external links still behaves as expected

Test Report: Link


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@michalrus michalrus requested review from a team May 23, 2023 16:21
@gabriela-ponce
Copy link

@michalrus It's not possible to pair Ledger devices, after running the Cardano app, there is an error on the console and the pairing can't proceed. Check this screenshot (Tested on Windows and macOS Intel, only reproduces for Ledger devices)

@tomislavhoracek
Copy link
Collaborator

@gabriela-ponce I will take a look. As I can see, Transport is working but communication with Cardano App ( LedgerJS ) is interrupted
cc @michalrus

@michalrus michalrus requested a review from gabriela-ponce May 30, 2023 12:13
@michalrus
Copy link
Member Author

@gabriela-ponce could you check once more? 🙏 Now it should work (I checked on all platforms)

Copy link

@gabriela-ponce gabriela-ponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on macOS (intel and M1) and Windows.
I'd wait for an additional review from @input-output-hk/daedalus-qa (in Linux, preferably) before merging.

@dmitrii-gaico dmitrii-gaico self-requested a review June 5, 2023 07:50
@michalrus michalrus force-pushed the chore/ddw-1213-update-electron branch from 49c7042 to 9105b4e Compare June 5, 2023 11:55
@miorsufianiohk miorsufianiohk self-requested a review June 6, 2023 08:37
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @michalrus 👍

@marcin-mazurek marcin-mazurek merged commit ffaace8 into develop Jun 6, 2023
@michalrus michalrus deleted the chore/ddw-1213-update-electron branch June 6, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants