-
Notifications
You must be signed in to change notification settings - Fork 298
[DDW-1213] Upgrade Electron to 24.2, and Node.js to 18.× #3124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@michalrus It's not possible to pair Ledger devices, after running the Cardano app, there is an error on the console and the pairing can't proceed. Check this screenshot (Tested on Windows and macOS Intel, only reproduces for Ledger devices) |
|
@gabriela-ponce I will take a look. As I can see, Transport is working but communication with Cardano App ( LedgerJS ) is interrupted |
|
@gabriela-ponce could you check once more? 🙏 Now it should work (I checked on all platforms) |
gabriela-ponce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on macOS (intel and M1) and Windows.
I'd wait for an additional review from @input-output-hk/daedalus-qa (in Linux, preferably) before merging.
49c7042 to
9105b4e
Compare
miorsufianiohk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work @michalrus 👍
This PR updates Electron and Node.js.
Direct trigger was our need for the
node:cryptobuilt-in module, which was not available in Node.js 14.×, but it's good to update either way.Also: all Windows blobs are now cross-built from source (still with Visual Studio).
Todos
Screenshots
n/a
Testing Checklist
Test Report: Link
Review Checklist
Basics
input-output-hk/daedalus-devandinput-output-hk/daedalus-qaassigned as PR reviewersrun Chromaticlabel to PR to trigger the run)release-vNext,feature/bug/chore,WIP)yarn manage:translationsproduces no changes)yarn storybook)yarn.lockfile is updatedCode Quality
Testing
After Review