[DDW-1222] Catalyst UI improvements

[marcin-mazurek]

This PR improves the Catalyst voting UI by removing confusing next fund snapshot date (we will only show info around the current fund) as well as removes any mentions of the fund number from the registration flow (since the user registers for Catalyst voting in general and not for a specific fund).

Screenshots

Testing Checklist

• Slack QA thread
• Test

---

Review Checklist

Basics

• PR assigned to the PR author(s)
• input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
• PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
• PR link is added to a Jira ticket, ticket moved to In Review
• PR is updated to the most recent version of the target branch (and there are no conflicts)
• PR has a good description that summarizes all changes
• PR contains screenshots (in case of UI changes)
• CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
• There are no missing translations (running yarn manage:translations produces no changes)
• Text changes are proofread and approved (Jane Wild / Amy Reeve)
• Japanese text changes are proofread and approved (Junko Oda)
• Storybook works and no stories are broken (yarn storybook)
• In case of dependency changes yarn.lock file is updated

Code Quality

• Important parts of the code are properly commented and documented
• Code is properly typed with typescript types
• React components are split-up enough to avoid unnecessary re-renderings
• Any code that only works in main process is neatly separated from components

Testing

• New feature/change is covered by acceptance tests
• New feature/change is manually tested and approved by QA team
• All existing acceptance tests are still up-to-date
• New feature/change is covered by Daedalus Testing scenario
• All existing Daedalus Testing scenarios are still up-to-date

After Review

• Update Slack QA thread by marking it with a green checkmark

[marcin-mazurek]

Replacing CHANGELOG entry on purpose - effectively, what was delivered in this unreleased PR, was deleted

[tomislavhoracek]

@marcin-mazurek nice job 💯

[marcin-mazurek]

Credits to @lucas-barros too ;)

[DominikGuzei]

much better like this 👏

[gabriela-ponce]

@marcin-mazurek this looks ok overall, but there is a detail with the default name of the pdf file on the last step.
Previously it was "fundXX-voting-registration-WalletName-Date.pdf". On the latest build the name is "fund-voting-registration-WalletName-Date.pdf". Maybe the word "fund" could be removed? It seems irrelevant now.

[marcin-mazurek]

@gabriela-ponce good point, I've replaced "fund" with "catalyst" - can you re-check?

[miorsufianiohk]

Hi @marcin-mazurek
The PR is looking good so far. However, I found an issue which is not related to this PR which I could reproduce on production and dev, The Newsletter link appears to be broken. So, I have been wondering if we are going to fix this at all? or whether in the scope of this PR or another PR? See screenshot

[marcin-mazurek]

@miorsufianiohk I asked Catalyst team to review all links, seems like there is more links that require updating. Good catch!

[miorsufianiohk]

LGTM. Great work @marcin-mazurek 👍